linux-kernel - Re: [PATCH v2 1/3] bus: moxtet: Mark the irq as shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231207154309.174a0753@dellmb>
Date:   Thu, 7 Dec 2023 15:43:09 +0100
From:   Marek Behún <kabel@...nel.org>
To:     Sjoerd Simons <sjoerd@...labora.com>
Cc:     kernel@...labora.com, stable@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] bus: moxtet: Mark the irq as shared

On Tue, 28 Nov 2023 22:35:04 +0100
Sjoerd Simons <sjoerd@...labora.com> wrote:

> The Turris Mox shares the moxtet IRQ with various devices on the board,
> so mark the IRQ as shared in the driver as well.
> 
> Without this loading the module will fail with:
>   genirq: Flags mismatch irq 40. 00002002 (moxtet) vs. 00002080 (mcp7940x)
> 
> Signed-off-by: Sjoerd Simons <sjoerd@...labora.com>
> Cc: stable@...r.kernel.org # v6.2+
> ---
> 
> (no changes since v1)
> 
>  drivers/bus/moxtet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
> index 5eb0fe73ddc4..48c18f95660a 100644
> --- a/drivers/bus/moxtet.c
> +++ b/drivers/bus/moxtet.c
> @@ -755,7 +755,7 @@ static int moxtet_irq_setup(struct moxtet *moxtet)
>  	moxtet->irq.masked = ~0;
>  
>  	ret = request_threaded_irq(moxtet->dev_irq, NULL, moxtet_irq_thread_fn,
> -				   IRQF_ONESHOT, "moxtet", moxtet);
> +				   IRQF_SHARED | IRQF_ONESHOT, "moxtet", moxtet);
>  	if (ret < 0)
>  		goto err_free;
>  

Reviewed-by: Marek Behún <kabel@...nel.org>