linux-kernel - Re: [PATCH v2 3/3] arm64: dts: armada-3720-turris-mox: set irq type for RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231207154336.5bf6272e@dellmb>
Date:   Thu, 7 Dec 2023 15:43:36 +0100
From:   Marek Behún <kabel@...nel.org>
To:     Sjoerd Simons <sjoerd@...labora.com>
Cc:     kernel@...labora.com, stable@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Conor Dooley <conor+dt@...nel.org>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: armada-3720-turris-mox: set irq type
 for RTC

On Tue, 28 Nov 2023 22:35:06 +0100
Sjoerd Simons <sjoerd@...labora.com> wrote:

> The rtc on the mox shares its interrupt line with the moxtet bus. Set
> the interrupt type to be consistent between both devices. This ensures
> correct setup of the interrupt line regardless of probing order.
> 
> Signed-off-by: Sjoerd Simons <sjoerd@...labora.com>
> Cc: stable@...r.kernel.org # v6.2+
> Fixes: 21aad8ba615e ("arm64: dts: armada-3720-turris-mox: Add missing interrupt for RTC")
> 
> ---
> 
> (no changes since v1)
> 
>  arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> index 9eab2bb22134..805ef2d79b40 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> @@ -130,7 +130,7 @@ rtc@6f {
>  		compatible = "microchip,mcp7940x";
>  		reg = <0x6f>;
>  		interrupt-parent = <&gpiosb>;
> -		interrupts = <5 0>; /* GPIO2_5 */
> +		interrupts = <5 IRQ_TYPE_EDGE_FALLING>; /* GPIO2_5 */
>  	};
>  };
>  

Reviewed-by: Marek Behún <kabel@...nel.org>