linux-kernel - Re: [PATCH net-next v1 1/4] octeon_ep: add PF-VF mailbox communication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202312090134.EZuetV2i-lkp@intel.com>
Date:   Sat, 9 Dec 2023 01:29:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Shinas Rasheed <srasheed@...vell.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, hgani@...vell.com,
        vimleshk@...vell.com, egallen@...hat.com, mschmidt@...hat.com,
        pabeni@...hat.com, horms@...nel.org, kuba@...nel.org,
        davem@...emloft.net, wizhao@...hat.com, kheib@...hat.com,
        konguyen@...hat.com, Shinas Rasheed <srasheed@...vell.com>,
        Veerasenareddy Burru <vburru@...vell.com>,
        Sathesh Edara <sedara@...vell.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next v1 1/4] octeon_ep: add PF-VF mailbox
 communication

Hi Shinas,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Shinas-Rasheed/octeon_ep-add-PF-VF-mailbox-communication/20231208-150756
base:   net-next/main
patch link:    https://lore.kernel.org/r/20231208070352.2606192-2-srasheed%40marvell.com
patch subject: [PATCH net-next v1 1/4] octeon_ep: add PF-VF mailbox communication
config: x86_64-randconfig-121-20231208 (https://download.01.org/0day-ci/archive/20231209/202312090134.EZuetV2i-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231209/202312090134.EZuetV2i-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312090134.EZuetV2i-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c: In function 'octep_poll_pfvf_mailbox_cnxk_pf':
>> drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c:406:6: warning: variable 'handled' set but not used [-Wunused-but-set-variable]
     int handled = 0;
         ^~~~~~~


vim +/handled +406 drivers/net/ethernet/marvell/octeon_ep/octep_cnxk_pf.c

   401	
   402	static void octep_poll_pfvf_mailbox_cnxk_pf(struct octep_device *oct)
   403	{
   404		u32 vf, active_vfs, active_rings_per_vf, vf_mbox_queue;
   405		u64 reg0;
 > 406		int handled = 0;
   407	
   408		reg0 = octep_read_csr64(oct, CNXK_SDP_EPF_MBOX_RINT(0));
   409		if (reg0) {
   410			active_vfs = CFG_GET_ACTIVE_VFS(oct->conf);
   411			active_rings_per_vf = CFG_GET_ACTIVE_RPVF(oct->conf);
   412			for (vf = 0; vf < active_vfs; vf++) {
   413				vf_mbox_queue = vf * active_rings_per_vf;
   414				if (!(reg0 & (0x1UL << vf_mbox_queue)))
   415					continue;
   416	
   417				if (!oct->mbox[vf_mbox_queue]) {
   418					dev_err(&oct->pdev->dev, "bad mbox vf %d\n", vf);
   419					continue;
   420				}
   421				schedule_work(&oct->mbox[vf_mbox_queue]->wk.work);
   422			}
   423			if (reg0)
   424				octep_write_csr64(oct, CNXK_SDP_EPF_MBOX_RINT(0), reg0);
   425	
   426			handled = 1;
   427		}
   428	}
   429	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki