linux-kernel - Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <493fe783-46b3-4da7-b0d9-01425e6adf2a@gmail.com>
Date:   Fri, 8 Dec 2023 18:49:38 +0100
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Gary Rookard <garyrookard@...tmail.org>, gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5) different
 variables

On 12/8/23 02:55, Gary Rookard wrote:
> Hi,
> 
> This patch series renames 5 different variables with the checkpatch
> coding style issue, Avoid CamelCase.
> 
> Patch 1/5) renamed variable bCurShortGI40MHz
> Patch 2/5) renamed variable bcurShortGI20MHz
> Patch 3/5) renamed variable CCKOFDMRate
> Patch 4/5) renamed variable HTIOTActIsCCDFsync
> Patch 5/5) renamed variable IOTPeer
> 
> Signed-off-by: Gary Rookard <garyrookard@...tmail.org>
> 
> 
> Gary Rookard (5):
>    staging: rtl8192e: renamed variable bCurShortGI40MHz
>    staging: rtl8192e: renamed variable bCurShortGI20MHz
>    staging: rtl8192e: renamed variable CCKOFDMRate
>    staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
>    staging: rtl8192e: renamed variable IOTPeer
> 
>   .../staging/rtl8192e/rtl8192e/r8192E_dev.c    |  4 +-
>   drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    | 22 +++----
>   drivers/staging/rtl8192e/rtl819x_HT.h         |  6 +-
>   drivers/staging/rtl8192e/rtl819x_HTProc.c     | 58 +++++++++----------
>   drivers/staging/rtl8192e/rtllib_tx.c          |  4 +-
>   5 files changed, 47 insertions(+), 47 deletions(-)
> 


Please use present-tense as outlined here:
https://kernelnewbies.org/PatchPhilosophy
So rename instead of renamed

Please use a more unique Subject for your coverletter.
It often cannot cover everything. But more unique is better.



Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>