linux-kernel - RE: [PATCH v6 1/3] misc: rtsx: add to support new card reader rts5264 new definition and function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6241bf49d5cb40329640e759cecd8f06@realtek.com>
Date:   Fri, 8 Dec 2023 03:27:17 +0000
From:   Ricky WU <ricky_wu@...ltek.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "arnd@...db.de" <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "frank.li@...o.com" <frank.li@...o.com>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: RE: [PATCH v6 1/3] misc: rtsx: add to support new card reader rts5264 new definition and function

> > in order to support NEW chip rts5264, the definitions of some internal
> > registers are define in new file rts5264.h, and some callback
> > functions and the workflow for rts5264 are define in new file
> > rts5264.c
> >
> > also add rts5264.o to Makefile
> >
> > Signed-off-by: Ricky Wu <ricky_wu@...ltek.com>
> > ---
> > v4: split new definition part up from v3
> > ---
> >  drivers/misc/cardreader/Makefile  |   2 +-
> >  drivers/misc/cardreader/rts5264.c | 886
> > ++++++++++++++++++++++++++++++  drivers/misc/cardreader/rts5264.h |
> > 278 ++++++++++
> >  3 files changed, 1165 insertions(+), 1 deletion(-)  create mode
> > 100644 drivers/misc/cardreader/rts5264.c  create mode 100644
> > drivers/misc/cardreader/rts5264.h
> 
> When building with this change applied, I get lots of build errors.  How did you
> test this?
> 
> My errors are:
> 
>   CC [M]  drivers/misc/cardreader/rts5264.o
> drivers/misc/cardreader/rts5264.c: In function ‘rts5264_process_ocp’:
> drivers/misc/cardreader/rts5264.c:398:40: error: ‘struct rtsx_pcr’ has no
> member named ‘ovp_stat’; did you mean ‘ocp_stat’?
>   398 |         rts5264_get_ovpstat(pcr, &pcr->ovp_stat);
>       |                                        ^~~~~~~~
>       |                                        ocp_stat
> drivers/misc/cardreader/rts5264.c:402:31: error: ‘struct rtsx_pcr’ has no
> member named ‘ovp_stat’; did you mean ‘ocp_stat’?
>   402 |                         (pcr->ovp_stat & (RTS5264_OVP_NOW |
> RTS5264_OVP_EVER))) {
>       |                               ^~~~~~~~
>       |                               ocp_stat
> drivers/misc/cardreader/rts5264.c:408:22: error: ‘struct rtsx_pcr’ has no
> member named ‘ovp_stat’; did you mean ‘ocp_stat’?
>   408 |                 pcr->ovp_stat = 0;
>       |                      ^~~~~~~~
>       |                      ocp_stat
> drivers/misc/cardreader/rts5264.c: In function ‘rts5264_extra_init_hw’:
> drivers/misc/cardreader/rts5264.c:534:38: error: ‘RTS5264_AUTOLOAD_CFG2’
> undeclared (first use in this function); did you mean
> ‘RTS5264_AUTOLOAD_CFG3’?
>   534 |         rtsx_pci_write_register(pcr, RTS5264_AUTOLOAD_CFG2,
>       |
> ^~~~~~~~~~~~~~~~~~~~~
>       |
> RTS5264_AUTOLOAD_CFG3
> drivers/misc/cardreader/rts5264.c:534:38: note: each undeclared identifier is
> reported only once for each function it appears in
> drivers/misc/cardreader/rts5264.c:535:25: error: ‘RTS5264_CHIP_RST_N_SEL’
> undeclared (first use in this function); did you mean
> ‘RTS5264_NON_XTAL_SEL’?
>   535 |                         RTS5264_CHIP_RST_N_SEL, 0);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~
>       |                         RTS5264_NON_XTAL_SEL
> drivers/misc/cardreader/rts5264.c:538:38: error: ‘CDGW’ undeclared (first
> use in this function)
>   538 |         rtsx_pci_write_register(pcr, CDGW, 0xFF, 0x01);
>       |                                      ^~~~
> drivers/misc/cardreader/rts5264.c: In function ‘rts5264_init_params’:
> drivers/misc/cardreader/rts5264.c:883:51: error: ‘SD_OVP_INT_EN’
> undeclared (first use in this function); did you mean ‘SD_OCP_INT_EN’?
>   883 |         hw_param->interrupt_en |= (SD_OC_INT_EN |
> SD_OVP_INT_EN);
>       |
> ^~~~~~~~~~~~~
>       |
> SD_OCP_INT_EN
> make[5]: *** [scripts/Makefile.build:243: drivers/misc/cardreader/rts5264.o]
> Error 1
> 
> 
> 
> Remember, each commit can not break the build.  Please fix up this series to
> build properly at each commit.
> 

Sorry for that, I sent the v7 to fix this issue, some definitions are defined in
Patch#2, I moved the file to Patch#1 in v7

Thank you

> thanks,
> 
> greg k-h