linux-kernel - RE: [PATCH v3 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Dec 2023 05:40:01 +0000
From:   James Tai [戴志峰] <james.tai@...ltek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: RE: [PATCH v3 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs

Hi Krzysztof,

>On 29/11/2023 06:43, James Tai wrote:
>> Add the YAML documentation for Realtek DHC (Digital Home Center) SoCs.
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes:
>> https://lore.kernel.org/oe-kbuild-all/202311180921.ayKhiFHL-lkp@intel.
>> com/
>
>Drop both. They are not applicable to this patch.
>
Okay. I will drop them.

>> CC: Thomas Gleixner <tglx@...utronix.de>
>> CC: Marc Zyngier <maz@...nel.org>
>
>> CC: Rob Herring <robh+dt@...nel.org>
>> CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
>> CC: Conor Dooley <conor+dt@...nel.org>
>> CC: linux-kernel@...r.kernel.org
>> CC: devicetree@...r.kernel.org
>
>Please drop the autogenerated scripts/get_maintainer.pl CC-entries from
>commit msg. There is no single need to store automated output of
>get_maintainers.pl in the git log. It can be easily re-created at any given time,
>thus its presence in the git history is redundant and obfuscates the log.
>
>If you need it for your own patch management purposes, keep it under the
>--- separator.
>
I will move the CC-entries under the '---' separator.

>My previous comments were not addressed. Why lines are not described
>(items: description:)? Are they all the same? Why you did not respond to clarify
>this comment?
>
I've addressed the previous comments and will include a description for each line in the next patches.
I misunderstood your meaning, so I did not provide a clear response.

>The rest of my comment here was also ignored. You cannot just ignore
>comments, but must respond to them or implement them.
>
I will improve this part.

>To clarify: I expect allOf: block after required: constraining the interrupts per
>variant.
>
I will adjust it in next patches.

Regards,
James