linux-kernel - drivers/iio/frequency/adf4377.c:498:19-48: duplicated argument to & or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 8 Dec 2023 07:36:17 +0100 (CET)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Antoniu Miclaus <antoniu.miclaus@...log.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Nuno Sá <nuno.sa@...log.com>,
        linux-kernel@...r.kernel.org, oe-kbuild-all@...ts.linux.dev
Subject: drivers/iio/frequency/adf4377.c:498:19-48: duplicated argument to
 & or | (fwd)

Maybe line 498 should contain ADF4377_0000_SOFT_RESET_MSK, not
ADF4377_0000_SOFT_RESET_R_MSK?

julia

---------- Forwarded message ----------
Date: Fri, 8 Dec 2023 06:19:53 +0800
From: kernel test robot <lkp@...el.com>
To: oe-kbuild@...ts.linux.dev
Cc: lkp@...el.com, Julia Lawall <julia.lawall@...ia.fr>
Subject: drivers/iio/frequency/adf4377.c:498:19-48: duplicated argument to & or
    |

BCC: lkp@...el.com
CC: oe-kbuild-all@...ts.linux.dev
CC: linux-kernel@...r.kernel.org
TO: Antoniu Miclaus <antoniu.miclaus@...log.com>
CC: Jonathan Cameron <Jonathan.Cameron@...wei.com>
CC: "Nuno Sá" <nuno.sa@...log.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   bee0e7762ad2c6025b9f5245c040fcc36ef2bde8
commit: eda549e2e52496d0d374ce457f514a4f14172aa5 iio: frequency: adf4377: add support for ADF4377
date:   1 year ago
:::::: branch date: 3 days ago
:::::: commit date: 1 year ago
config: x86_64-randconfig-101-20231208 (https://download.01.org/0day-ci/archive/20231208/202312080606.0wEO9f5h-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20231208/202312080606.0wEO9f5h-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Julia Lawall <julia.lawall@...ia.fr>
| Closes: https://lore.kernel.org/r/202312080606.0wEO9f5h-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/iio/frequency/adf4377.c:498:19-48: duplicated argument to & or |

vim +498 drivers/iio/frequency/adf4377.c

eda549e2e52496 Antoniu Miclaus 2022-11-15  484
eda549e2e52496 Antoniu Miclaus 2022-11-15  485  static int adf4377_soft_reset(struct adf4377_state *st)
eda549e2e52496 Antoniu Miclaus 2022-11-15  486  {
eda549e2e52496 Antoniu Miclaus 2022-11-15  487  	unsigned int read_val;
eda549e2e52496 Antoniu Miclaus 2022-11-15  488  	int ret;
eda549e2e52496 Antoniu Miclaus 2022-11-15  489
eda549e2e52496 Antoniu Miclaus 2022-11-15  490  	ret = regmap_update_bits(st->regmap, 0x0, ADF4377_0000_SOFT_RESET_MSK |
eda549e2e52496 Antoniu Miclaus 2022-11-15  491  				 ADF4377_0000_SOFT_RESET_R_MSK,
eda549e2e52496 Antoniu Miclaus 2022-11-15  492  				 FIELD_PREP(ADF4377_0000_SOFT_RESET_MSK, 1) |
eda549e2e52496 Antoniu Miclaus 2022-11-15  493  				 FIELD_PREP(ADF4377_0000_SOFT_RESET_R_MSK, 1));
eda549e2e52496 Antoniu Miclaus 2022-11-15  494  	if (ret)
eda549e2e52496 Antoniu Miclaus 2022-11-15  495  		return ret;
eda549e2e52496 Antoniu Miclaus 2022-11-15  496
eda549e2e52496 Antoniu Miclaus 2022-11-15  497  	return regmap_read_poll_timeout(st->regmap, 0x0, read_val,
eda549e2e52496 Antoniu Miclaus 2022-11-15 @498  					!(read_val & (ADF4377_0000_SOFT_RESET_R_MSK |
eda549e2e52496 Antoniu Miclaus 2022-11-15  499  					ADF4377_0000_SOFT_RESET_R_MSK)), 200, 200 * 100);
eda549e2e52496 Antoniu Miclaus 2022-11-15  500  }
eda549e2e52496 Antoniu Miclaus 2022-11-15  501

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki