linux-kernel - RE: [EXT] [PATCH] [v2] ethernet: atheros: fix a memleak in atl1e_setup_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR18MB5216FB178B2DD2760A3C9C7EDB8AA@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date:   Fri, 8 Dec 2023 08:51:14 +0000
From:   Suman Ghosh <sumang@...vell.com>
To:     Zhipeng Lu <alexious@....edu.cn>
CC:     Chris Snook <chris.snook@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Simon Horman <horms@...nel.org>,
        Yuanjun Gong <ruc_gongyuanjun@....com>,
        Jie Yang <jie.yang@...eros.com>,
        Jeff Garzik <jgarzik@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH] [v2] ethernet: atheros: fix a memleak in
 atl1e_setup_ring_resources

>In the error handling of 'offset > adapter->ring_size', the tx_ring-
>>tx_buffer allocated by kzalloc should be freed, instead of 'goto
>failed' instantly.
>
>Fixes: a6a5325239c2 ("atl1e: Atheros L1E Gigabit Ethernet driver")
>Signed-off-by: Zhipeng Lu <alexious@....edu.cn>
>---
Reviewed-by: Suman Ghosh <sumang@...vell.com>
>
>Changelog:
>
>v2: Setting tx_ring->tx_buffer to NULL after free.