[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2b646678611c3ed7546d880f8875d57a6800c281.camel@maquefel.me>
Date: Fri, 08 Dec 2023 14:10:29 +0300
From: Nikita Shubin <nikita.shubin@...uefel.me>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Hartley Sweeten <hsweeten@...ionengravers.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Alexander Sverdlin <alexander.sverdlin@...il.com>,
Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v5 17/39] net: cirrus: add DT support for Cirrus EP93xx
Hello Andy!
Thanks for review (i am counting all review not only this patch), only
this comment below raised a question:
On Wed, 2023-11-22 at 14:16 +0200, Andy Shevchenko wrote:
> On Wed, Nov 22, 2023 at 11:59:55AM +0300, Nikita Shubin wrote:
> > - add OF ID match table
> > - get phy_id from the device tree, as part of mdio
> > - copy_addr is now always used, as there is no SoC/board that
> > aren't
> > - dropped platform header
>
> ...
>
> > #include <linux/interrupt.h>
> > #include <linux/moduleparam.h>
> > #include <linux/platform_device.h>
> > +#include <linux/of.h>
>
> Perhaps more ordering?
>
> > #include <linux/delay.h>
> > #include <linux/io.h>
> > #include <linux/slab.h>
>
> ...
>
> > + err = of_property_read_u32(np, "reg", &phy_id);
> > + of_node_put(np);
> > + if (err)
> > + return dev_err_probe(&pdev->dev, -ENOENT, "Failed
> > to locate \"phy_id\"\n");
>
> Why shadowing the actual error code?
of_property_read_u32 returns NULL on error.
>
> > +
> > + dev = alloc_etherdev(sizeof(struct ep93xx_priv));
> > if (dev == NULL) {
> > err = -ENOMEM;
> > goto err_out;
> > }
>
Powered by blists - more mailing lists