linux-kernel - Re: [PATCH v2] i2c: cpm: Remove linux,i2c-index conversion from be32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <950ac94b-f488-4879-973e-4014f224c62f@scram.de>
Date:   Fri, 8 Dec 2023 12:12:13 +0100
From:   Jochen Friedrich <jochen@...am.de>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Andi Shyti <andi.shyti@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-i2c@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] i2c: cpm: Remove linux,i2c-index conversion from be32

Acked-By: Jochen Friedrich <jochen@...am.de>

Am 06.12.2023 um 23:24 schrieb Christophe Leroy:
> sparse reports an error on some data that gets converted from be32.
>
> That's because that data is typed u32 instead of __be32.
>
> The type is correct, the be32_to_cpu() conversion is not.
>
> Remove the conversion.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312042210.QL4DA8Av-lkp@intel.com/
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> ---
> v2: Use u32 directly, remove be32_to_cpu().
> ---
>   drivers/i2c/busses/i2c-cpm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
> index 9a664abf734d..771d60bc8d71 100644
> --- a/drivers/i2c/busses/i2c-cpm.c
> +++ b/drivers/i2c/busses/i2c-cpm.c
> @@ -658,7 +658,7 @@ static int cpm_i2c_probe(struct platform_device *ofdev)
>   	/* register new adapter to i2c module... */
>   
>   	data = of_get_property(ofdev->dev.of_node, "linux,i2c-index", &len);
> -	cpm->adap.nr = (data && len == 4) ? be32_to_cpup(data) : -1;
> +	cpm->adap.nr = (data && len == 4) ? *data : -1;
>   	result = i2c_add_numbered_adapter(&cpm->adap);
>   
>   	if (result < 0)