linux-kernel - Re: [PATCH 0/3] nfsd: fully close all files in the nfsd threads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c850d6606abb4be23090ed8a947722a06997aa42.camel@kernel.org>
Date:   Fri, 08 Dec 2023 06:40:50 -0500
From:   Jeff Layton <jlayton@...nel.org>
To:     NeilBrown <neilb@...e.de>, Al Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>,
        Jens Axboe <axboe@...nel.dk>, Oleg Nesterov <oleg@...hat.com>,
        Chuck Lever <chuck.lever@...cle.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-nfs@...r.kernel.org
Subject: Re: [PATCH 0/3] nfsd: fully close all files in the nfsd threads

On Fri, 2023-12-08 at 14:27 +1100, NeilBrown wrote:
> This is a new version of my patches to address a rare problem with nfsd
> closing files faster than __fput() can complete the close in a different
> thread.
> 
> This time I'm simply switching to __fput_sync().  I cannot see any
> reason that this would be a problem, but if any else does and can show
> me what I'm missing, I'd appreciate it.
> 
> Thanks,
> NeilBrown
> 
> 
>  [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of
>  [PATCH 2/3] nfsd: Don't leave work of closing files to a work queue.
>  [PATCH 3/3] VFS: don't export flush_delayed_fput().

Looks good to me.

Reviewed-by: Jeff Layton <jlayton@...nel.org>