linux-kernel - RE: [PATCH v2] crypto: virtio-crypto: Handle dataq logic with tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <70ea58a0776e4ba2a38658047d188688@huawei.com>
Date:   Fri, 8 Dec 2023 12:18:10 +0000
From:   "Gonglei (Arei)" <arei.gonglei@...wei.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        wangyangxin <wangyangxin1@...wei.com>,
        "Halil Pasic" <pasic@...ux.ibm.com>
Subject: RE: [PATCH v2] crypto: virtio-crypto: Handle dataq logic  with
 tasklet



> -----Original Message-----
> From: Herbert Xu [mailto:herbert@...dor.apana.org.au]
> Sent: Friday, December 8, 2023 11:28 AM
> To: Gonglei (Arei) <arei.gonglei@...wei.com>
> Cc: linux-crypto@...r.kernel.org; Michael S. Tsirkin <mst@...hat.com>; Jason
> Wang <jasowang@...hat.com>; virtualization@...ts.linux-foundation.org;
> linux-kernel@...r.kernel.org; wangyangxin <wangyangxin1@...wei.com>;
> Halil Pasic <pasic@...ux.ibm.com>
> Subject: Re: [PATCH v2] crypto: virtio-crypto: Handle dataq logic with tasklet
> 
> On Wed, Dec 06, 2023 at 11:52:51AM +0000, Gonglei (Arei) wrote:
> > Doing ipsec produces a spinlock recursion warning.
> > This is due to crypto_finalize_request() being called in the upper half.
> > Move virtual data queue processing of virtio-crypto driver to tasklet.
> >
> > Fixes: dbaf0624ffa5 ("crypto: add virtio-crypto driver")
> > Reported-by: Halil Pasic <pasic@...ux.ibm.com>
> > Signed-off-by: wangyangxin <wangyangxin1@...wei.com>
> > Signed-off-by: Gonglei <arei.gonglei@...wei.com>
> > ---
> >  v2: calling tasklet_kill() in virtcrypto_remove(), thanks for MST.
> >
> >  drivers/crypto/virtio/virtio_crypto_common.h |  2 ++
> >  drivers/crypto/virtio/virtio_crypto_core.c   | 26
> ++++++++++++++++----------
> >  2 files changed, 18 insertions(+), 10 deletions(-)
> 
> Your patch has already been merged.  So please send this as an incremental
> patch.
> 

OK. No problem. 

Regards,
-Gonglei

> Thanks,
> --
> Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt