linux-kernel - Re: [PATCH 08/27] tty: con3215: convert to u8 and size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXMX3y/75ugvzk9L@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
Date:   Fri, 8 Dec 2023 14:19:27 +0100
From:   Alexander Gordeev <agordeev@...ux.ibm.com>
To:     "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, linux-s390@...r.kernel.org
Subject: Re: [PATCH 08/27] tty: con3215: convert to u8 and size_t

On Wed, Dec 06, 2023 at 08:36:53AM +0100, Jiri Slaby (SUSE) wrote:
> Switch character types to u8 and sizes to size_t. To conform to
> characters/sizes in the rest of the tty layer.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Alexander Gordeev <agordeev@...ux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Cc: Sven Schnelle <svens@...ux.ibm.com>
> Cc: linux-s390@...r.kernel.org
> ---
>  drivers/s390/char/con3215.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
> index 34bc343dcfcc..0b0324fe4aff 100644
> --- a/drivers/s390/char/con3215.c
> +++ b/drivers/s390/char/con3215.c
> @@ -79,8 +79,8 @@ struct raw3215_info {
>  	struct ccw_device *cdev;      /* device for tty driver */
>  	spinlock_t *lock;	      /* pointer to irq lock */
>  	int flags;		      /* state flags */
> -	char *buffer;		      /* pointer to output buffer */
> -	char *inbuf;		      /* pointer to input buffer */
> +	u8 *buffer;		      /* pointer to output buffer */
> +	u8 *inbuf;		      /* pointer to input buffer */
>  	int head;		      /* first free byte in output buffer */
>  	int count;		      /* number of bytes in output buffer */
>  	int written;		      /* number of bytes in write requests */
> @@ -522,12 +522,14 @@ static unsigned int raw3215_make_room(struct raw3215_info *raw,
>   *	string	without blocking.
>   *	Return value is the number of bytes copied.
>   */
> -static unsigned int raw3215_addtext(const char *str, unsigned int length,
> +static unsigned int raw3215_addtext(const u8 *str, size_t length,
>  				    struct raw3215_info *raw, int opmode,
>  				    unsigned int todrop)
>  {
> -	unsigned int c, ch, i, blanks, expanded_size = 0;
> +	unsigned int i, blanks, expanded_size = 0;
>  	unsigned int column = raw->line_pos;
> +	size_t c;
> +	u8 ch;
>  
>  	if (opmode == RAW3215_COUNT)
>  		todrop = 0;
> @@ -558,7 +560,7 @@ static unsigned int raw3215_addtext(const char *str, unsigned int length,
>  		if (todrop && expanded_size < todrop)	/* Drop head data */
>  			continue;
>  		for (i = 0; i < blanks; i++) {
> -			raw->buffer[raw->head] = (char)_ascebc[(int)ch];
> +			raw->buffer[raw->head] = _ascebc[ch];
>  			raw->head = (raw->head + 1) & (RAW3215_BUFFER_SIZE - 1);
>  			raw->count++;
>  		}
> @@ -570,8 +572,8 @@ static unsigned int raw3215_addtext(const char *str, unsigned int length,
>  /*
>   * String write routine for 3215 devices
>   */
> -static void raw3215_write(struct raw3215_info *raw, const char *str,
> -			  unsigned int length)
> +static void raw3215_write(struct raw3215_info *raw, const u8 *str,
> +			  size_t length)
>  {
>  	unsigned int count, avail;
>  	unsigned long flags;
> @@ -596,7 +598,7 @@ static void raw3215_write(struct raw3215_info *raw, const char *str,
>  /*
>   * Put character routine for 3215 devices
>   */
> -static void raw3215_putchar(struct raw3215_info *raw, unsigned char ch)
> +static void raw3215_putchar(struct raw3215_info *raw, u8 ch)
>  {
>  	raw3215_write(raw, &ch, 1);
>  }
> @@ -823,12 +825,10 @@ static struct ccw_driver raw3215_ccw_driver = {
>  	.int_class	= IRQIO_C15,
>  };
>  
> -static void handle_write(struct raw3215_info *raw, const char *str, int count)
> +static void handle_write(struct raw3215_info *raw, const u8 *str, size_t count)
>  {
> -	int i;
> -
>  	while (count > 0) {
> -		i = min_t(int, count, RAW3215_BUFFER_SIZE - 1);
> +		size_t i = min_t(size_t, count, RAW3215_BUFFER_SIZE - 1);
>  		raw3215_write(raw, str, i);
>  		count -= i;
>  		str += i;

Acked-by: Alexander Gordeev <agordeev@...ux.ibm.com>