linux-kernel - Re: [PATCH 4/5] platform/x86: wmi: Remove chardev interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92e2d5f-77cd-30b0-64e5-28f767baf776@linux.intel.com>
Date:   Fri, 8 Dec 2023 15:43:23 +0200 (EET)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Armin Wolf <W_Armin@....de>
cc:     Hans de Goede <hdegoede@...hat.com>, corbet@....net,
        Dell.Client.Kernel@...l.com, linux-doc@...r.kernel.org,
        platform-driver-x86@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] platform/x86: wmi: Remove chardev interface

On Thu, 7 Dec 2023, Armin Wolf wrote:

> The design of the WMI chardev interface is broken:
> - it assumes that WMI drivers are not instantiated twice
> - it offers next to no abstractions, the WMI driver gets
> a raw byte buffer
> - it is only used by a single driver, something which is
> unlikely to change
> 
> Since the only user (dell-smbios-wmi) has been migrated
> to his own ioctl interface, remove it.
> 
> Signed-off-by: Armin Wolf <W_Armin@....de>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.