linux-kernel - Re: [PATCH] platform/x86: thinkpad_acpi: fix for incorrect fan reporting on some ThinkPad systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1c4ac4ba-5648-4404-8253-30ea19796762@app.fastmail.com>
Date:   Fri, 08 Dec 2023 09:01:35 -0500
From:   "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        "Vishnu Sankar" <vishnuocv@...il.com>
Cc:     "Hans de Goede" <hdegoede@...hat.com>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        linux-kernel@...r.kernel.org,
        "markgross@...nel.org" <markgross@...nel.org>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: fix for incorrect fan reporting on
 some ThinkPad systems

Thanks Ilpo

On Fri, Dec 8, 2023, at 5:53 AM, Ilpo Järvinen wrote:
> On Thu, 7 Dec 2023, Vishnu Sankar wrote:
>
> Hi Vishnu,
>
> Thanks for the patch.
>
>> Some ThinkPad systems ECFW use non-standard addresses for fan control
>> and reporting. This patch adds support for such ECFW so that it can report
>> the correct fan values.
>> Tested on Thinkpads L13 Yoga Gen 2 and X13 Yoga Gen 2.
>> 
>> Co-developed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
>> Signed-off-by: Vishnu Sankar <vishnuocv@...il.com>
>
> If Mark wrote any lines, his Signed-off-by is also required before yours,
> as per Documentation/process/5.Posting.rst, this is a hard requirement. 
>
> If he only helped towards the right direction/solution but provided no 
> code, I recommend using Suggested-by tag instead.
>
Ah - I didn't know that. Thanks for the clarification.

I should probably be a Suggested-by here. I've been helping Vishnu with the process but he's been doing all the hard work and writing of code.

Mark