linux-kernel - Re: [PATCH] ksmbd: validate the zero field of packet header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd9t-J+BV72u_JdYD=MrOyat1Nx1=Jo8rBa59qtsrNviDg@mail.gmail.com>
Date:   Fri, 8 Dec 2023 23:20:59 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     linan666@...weicloud.com
Cc:     sfrench@...ba.org, linux-cifs@...r.kernel.org,
        linux-kernel@...r.kernel.org, linan122@...wei.com,
        yukuai3@...wei.com, yi.zhang@...wei.com, houtao1@...wei.com,
        yangerkun@...wei.com
Subject: Re: [PATCH] ksmbd: validate the zero field of packet header

2023-12-08 15:56 GMT+09:00, linan666@...weicloud.com <linan666@...weicloud.com>:
> From: Li Nan <linan122@...wei.com>
>
> The SMB2 Protocol requires that "The first byte of the Direct TCP
> transport packet header MUST be zero (0x00)"[1]. Commit 1c1bcf2d3ea0
> ("ksmbd: validate smb request protocol id") removed the validation of
> this 1-byte zero. Add the validation back now.
>
> [1]: [MS-SMB2] - v20230227, page 30.
> https://winprotocoldoc.blob.core.windows.net/productionwindowsarchives/MS-SMB2/%5bMS-SMB2%5d-230227.pdf
>
> Fixes: 1c1bcf2d3ea0 ("ksmbd: validate smb request protocol id")
> Signed-off-by: Li Nan <linan122@...wei.com>
Acked-by: Namjae Jeon <linkinjeon@...nel.org>
Applied it to #ksmbd-for-next-next.
Thanks for your patch!