linux-kernel - Re: [PATCH v5 iwl-next] i40e: Use correct buffer size in i40e_dbg_command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa3cb4da-fce1-4496-ae5a-78133c4b540d@intel.com>
Date:   Fri, 8 Dec 2023 16:00:59 +0100
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Kunwu Chan <chentao@...inos.cn>
CC:     <jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <jeffrey.t.kirsher@...el.com>,
        <shannon.nelson@....com>, <intel-wired-lan@...ts.osuosl.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Simon Horman <horms@...nel.org>,
        Kunwu Chan <kunwu.chan@...mail.com>
Subject: Re: [PATCH v5 iwl-next] i40e: Use correct buffer size in
 i40e_dbg_command_read

From: Kunwu Chan <chentao@...inos.cn>
Date: Fri, 8 Dec 2023 11:19:50 +0800

> The size of "i40e_dbg_command_buf" is 256, the size of "name"
> depends on "IFNAMSIZ", plus a null character and format size,
> the total size is more than 256.
> 
> Improve readability and maintainability by replacing a hardcoded string
> allocation and formatting by the use of the kasprintf() helper.
> 
> Fixes: 02e9c290814c ("i40e: debugfs interface")
> Suggested-by: Simon Horman <horms@...nel.org>
> Suggested-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Suggested-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> Cc: Kunwu Chan <kunwu.chan@...mail.com>
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

Thanks,
Olek