linux-kernel - RE: [PATCH v3 4/4] mm/slub: correct the default value of slub_min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 9 Dec 2023 13:59:47 +0000
From:   "Song, Xiongwei" <Xiongwei.Song@...driver.com>
To:     "sxwjean@...com" <sxwjean@...com>,
        "vbabka@...e.cz" <vbabka@...e.cz>,
        "42.hyeyoo@...il.com" <42.hyeyoo@...il.com>,
        "cl@...ux.com" <cl@...ux.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>
CC:     "penberg@...nel.org" <penberg@...nel.org>,
        "rientjes@...gle.com" <rientjes@...gle.com>,
        "iamjoonsoo.kim@....com" <iamjoonsoo.kim@....com>,
        "roman.gushchin@...ux.dev" <roman.gushchin@...ux.dev>,
        "corbet@....net" <corbet@....net>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 4/4] mm/slub: correct the default value of
 slub_min_objects in doc

Hi Vlastimil,

I didn't change description as you mentioned because slab_min_objects doesn't
save the calculated value based on the number of processors, but the local
variables min_objects doesn't.

Regards,
Xiongwei 

> -----Original Message-----
> From: owner-linux-mm@...ck.org <owner-linux-mm@...ck.org> On Behalf Of
> sxwjean@...com
> Sent: Saturday, December 9, 2023 9:52 PM
> To: vbabka@...e.cz; 42.hyeyoo@...il.com; cl@...ux.com; linux-mm@...ck.org
> Cc: penberg@...nel.org; rientjes@...gle.com; iamjoonsoo.kim@....com;
> roman.gushchin@...ux.dev; corbet@....net; keescook@...omium.org; arnd@...db.de;
> akpm@...ux-foundation.org; gregkh@...uxfoundation.org; linux-doc@...r.kernel.org; linux-
> kernel@...r.kernel.org; Song, Xiongwei <Xiongwei.Song@...driver.com>
> Subject: [PATCH v3 4/4] mm/slub: correct the default value of slub_min_objects in doc
> 
> From: Xiongwei Song <xiongwei.song@...driver.com>
> 
> There is no a value assigned to slub_min_objects by default, it always
> is 0 that is initialized by compiler if no assigned value by command line.
> min_objects is calculated based on processor numbers in calculate_order().
> For more details, see commit 9b2cd506e5f2 ("slub: Calculate min_objects
> based on number of processors.")
> 
> Signed-off-by: Xiongwei Song <xiongwei.song@...driver.com>
> ---
>  Documentation/mm/slub.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/mm/slub.rst b/Documentation/mm/slub.rst
> index 6579a55b7852..56b27f493ba7 100644
> --- a/Documentation/mm/slub.rst
> +++ b/Documentation/mm/slub.rst
> @@ -150,7 +150,7 @@ list_lock once in a while to deal with partial slabs. That overhead is
>  governed by the order of the allocation for each slab. The allocations
>  can be influenced by kernel parameters:
> 
> -.. slab_min_objects=x          (default 4)
> +.. slab_min_objects=x          (default 0)
>  .. slab_min_order=x            (default 0)
>  .. slab_max_order=x            (default 3 (PAGE_ALLOC_COSTLY_ORDER))
> 
> --
> 2.34.1
>