linux-kernel - Re: [PATCH] Added support for Zen 3 based AMD Threadrippers (5000WX series). They were previously under Zen3 SP models, but this was incorrect.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c35ac10-2768-4d9b-aad8-091ea17ee92d@roeck-us.net>
Date:   Sat, 9 Dec 2023 15:25:18 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     bindkeys@...il.com, Clemens Ladisch <clemens@...isch.de>,
        Jean Delvare <jdelvare@...e.com>
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Added support for Zen 3 based AMD Threadrippers (5000WX
 series). They were previously under Zen3 SP models, but this was incorrect.

On 12/9/23 15:15, bindkeys@...il.com wrote:
> From: Jami Kurki <bindkeys@...il.com>
> 
> Signed-off-by: Jami Kurki <bindkeys@...il.com>

This is not an appropriate patch subject and description.

Please follow Documentation/process/submitting-patches.rst,
"The canonical patch format".

Thanks,
Guenter

> ---
>   drivers/hwmon/k10temp.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index bae0becfa24b..b5738dd8d442 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -454,7 +454,8 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   		data->is_zen = true;
>   
>   		switch (boot_cpu_data.x86_model) {
> -		case 0x0 ... 0x1:	/* Zen3 SP3/TR */
> +		case 0x0 ... 0x1:	/* Zen3 SP3 */
> +		case 0x8:		/* Zen3 TR */
>   		case 0x21:		/* Zen3 Ryzen Desktop */
>   		case 0x50 ... 0x5f:	/* Green Sardine */
>   			data->ccd_offset = 0x154;