lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <fad8a055-eabb-4087-94d5-9e1de00933e4@amd.com> Date: Sun, 10 Dec 2023 09:00:44 +0530 From: Venkata Prasad Potturu <venkataprasad.potturu@....com> To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>, Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>, Bard Liao <yung-chuan.liao@...ux.intel.com>, Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>, Daniel Baluta <daniel.baluta@....com>, Kai Vehmanen <kai.vehmanen@...ux.intel.com>, Alper Nebi Yasak <alpernebiyasak@...il.com>, Syed Saba Kareem <Syed.SabaKareem@....com>, Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>, Marian Postevca <posteuca@...ex.one>, Vijendar Mukunda <Vijendar.Mukunda@....com>, V sujith kumar Reddy <Vsujithkumar.Reddy@....com>, Mastan Katragadda <Mastan.Katragadda@....com>, Ajit Kumar Pandey <AjitKumar.Pandey@....com> Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, sound-open-firmware@...a-project.org, kernel@...labora.com Subject: Re: [PATCH 11/11] ASoC: SOF: topology: Add new DAI type entry for SOF_DAI_AMD_BT On 12/10/23 02:23, Cristian Ciocaltea wrote: > Commit efb931cdc4b9 ("ASoC: SOF: topology: Add support for AMD ACP > DAIs") registered "ACP" name for SOF_DAI_AMD_BT DAI type. However, some > boards, i.e. Steam Deck OLED, seem to require "ACPBT" for the same type: > > [ 467.489680] snd_sof_amd_vangogh 0000:04:00.5: ipc tx error for 0x30030000 (msg/reply size: 16/0): -22 > [ 467.492775] snd_sof_amd_vangogh 0000:04:00.5: sof_ipc3_route_setup: route ACPBT2.IN -> BUF5.0 failed > [ 467.495839] snd_sof_amd_vangogh 0000:04:00.5: sof_ipc3_set_up_all_pipelines: route set up failed > [ 467.499128] snd_sof_amd_vangogh 0000:04:00.5: error: tplg component load failed -22 > [ 467.502210] snd_sof_amd_vangogh 0000:04:00.5: error: failed to load DSP topology -22 > [ 467.505289] snd_sof_amd_vangogh 0000:04:00.5: ASoC: error at snd_soc_component_probe on 0000:04:00.5: -22 > [ 467.508430] sof_mach nau8821-max: ASoC: failed to instantiate card -22 > [ 467.511725] sof_mach nau8821-max: error -EINVAL: Failed to register card(sof-nau8821-max) > [ 467.514861] sof_mach: probe of nau8821-max failed with error -22 > > Add "ACPBT" alias for "ACP" SOF DAI type. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com> > --- > sound/soc/sof/topology.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c > index e3e7fbe40fa6..73bf791e7520 100644 > --- a/sound/soc/sof/topology.c > +++ b/sound/soc/sof/topology.c > @@ -290,6 +290,7 @@ static const struct sof_dai_types sof_dais[] = { > {"SAI", SOF_DAI_IMX_SAI}, > {"ESAI", SOF_DAI_IMX_ESAI}, > {"ACP", SOF_DAI_AMD_BT}, > + {"ACPBT", SOF_DAI_AMD_BT}, No need to create the alias name, we can directly modify ACP to ACPBT as ACP is not using anywhere. > {"ACPSP", SOF_DAI_AMD_SP}, > {"ACPDMIC", SOF_DAI_AMD_DMIC}, > {"ACPHS", SOF_DAI_AMD_HS},
Powered by blists - more mailing lists