linux-kernel - [PATCH] staging:vme_user:fix the issue of using the wrong error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231211155453.105409-1-piroyangg@gmail.com>
Date:   Mon, 11 Dec 2023 23:54:53 +0800
From:   Piro Yang <piroyangg@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Piro Yang <piroyangg@...il.com>, linux-staging@...ts.linux.dev,
        Linux Outreachy <outreachy@...ts.linux.dev>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] staging:vme_user:fix the issue of using the wrong error code

1. the error code of ENOSYS indicates Invalid system call number,
   but there is not system call

2. unified the logging error message, when slave_set func is NULL

Signed-off-by: Piro Yang <piroyangg@...il.com>
---
 drivers/staging/vme_user/vme.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index 5c416c31ec57..e9461a7a7ab8 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -340,8 +340,8 @@ int vme_slave_set(struct vme_resource *resource, int enabled,
 	image = list_entry(resource->entry, struct vme_slave_resource, list);
 
 	if (!bridge->slave_set) {
-		dev_err(bridge->parent, "Function not supported\n");
-		return -ENOSYS;
+		dev_err(bridge->parent, "%s not supported\n", __func__);
+		return -EINVAL;
 	}
 
 	if (!(((image->address_attr & aspace) == aspace) &&
-- 
2.25.1