linux-kernel - Re: [RFC PATCH 05/12] lib/raid6: Use CC_FLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXczty+Y6dTDL4Xi@infradead.org>
Date:   Mon, 11 Dec 2023 08:07:19 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Samuel Holland <samuel.holland@...ive.com>
Cc:     linux-arm-kernel@...ts.infradead.org, loongarch@...ts.linux.dev,
        linuxppc-dev@...ts.ozlabs.org, x86@...nel.org,
        linux-riscv@...ts.infradead.org,
        Christoph Hellwig <hch@...radead.org>,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        linux-arch@...r.kernel.org
Subject: Re: [RFC PATCH 05/12] lib/raid6: Use CC_FLAGS_FPU for NEON CFLAGS

> +CFLAGS_REMOVE_neon1.o += $(CC_FLAGS_NO_FPU)
> +CFLAGS_REMOVE_neon2.o += $(CC_FLAGS_NO_FPU)
> +CFLAGS_REMOVE_neon4.o += $(CC_FLAGS_NO_FPU)
> +CFLAGS_REMOVE_neon8.o += $(CC_FLAGS_NO_FPU)

Btw, do we even really need the extra variables for compiler flags
to remove?  Don't gcc/clang options work so that if you add a
no-prefixed version of the option later it transparently gets removed?

Except for that:

Reviewed-by: Christoph Hellwig <hch@....de>