[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <07d71c9b-45e0-4d51-9449-68d40a46449e@collabora.com>
Date: Mon, 11 Dec 2023 18:56:25 +0200
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Emil Velikov <emil.velikov@...labora.com>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
Bard Liao <yung-chuan.liao@...ux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
Daniel Baluta <daniel.baluta@....com>,
Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
Venkata Prasad Potturu <venkataprasad.potturu@....com>,
Alper Nebi Yasak <alpernebiyasak@...il.com>,
Syed Saba Kareem <Syed.SabaKareem@....com>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
Marian Postevca <posteuca@...ex.one>,
Vijendar Mukunda <Vijendar.Mukunda@....com>,
V sujith kumar Reddy <Vsujithkumar.Reddy@....com>,
Mastan Katragadda <Mastan.Katragadda@....com>,
Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
sound-open-firmware@...a-project.org, kernel@...labora.com
Subject: Re: [PATCH 03/11] ASoC: amd: acp: Add missing error handling in
sof-mach
On 12/11/23 15:31, Emil Velikov wrote:
> On 2023/12/09, Cristian Ciocaltea wrote:
>> Handle potential acp_sofdsp_dai_links_create() errors in ACP SOF machine
>> driver's probe function. Additionally, switch to dev_err_probe().
>>
>> Fixes: 9f84940f5004 ("ASoC: amd: acp: Add SOF audio support on Chrome board")
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
>> ---
>> sound/soc/amd/acp/acp-sof-mach.c | 14 ++++++--------
>> 1 file changed, 6 insertions(+), 8 deletions(-)
>>
>> diff --git a/sound/soc/amd/acp/acp-sof-mach.c b/sound/soc/amd/acp/acp-sof-mach.c
>> index 1d313fcb5f2d..6f0ca23638af 100644
>> --- a/sound/soc/amd/acp/acp-sof-mach.c
>> +++ b/sound/soc/amd/acp/acp-sof-mach.c
>> @@ -112,16 +112,14 @@ static int acp_sof_probe(struct platform_device *pdev)
>> if (dmi_id && dmi_id->driver_data)
>> acp_card_drvdata->tdm_mode = dmi_id->driver_data;
>>
>> - acp_sofdsp_dai_links_create(card);
>> + ret = acp_sofdsp_dai_links_create(card);
>> + if (ret)
>> + return dev_err_probe(&pdev->dev, ret, "Failed to create DAI links\n");
>>
>> ret = devm_snd_soc_register_card(&pdev->dev, card);
>> - if (ret) {
>> - dev_err(&pdev->dev,
>> - "devm_snd_soc_register_card(%s) failed: %d\n",
>> - card->name, ret);
>> - return ret;
>> - }
>> -
>> + if (ret)
>
> Do we need to undo acp_sofdsp_dai_links_create() in here? If not, please
> add a trivial note in the commit message.
No need to undo, will update the commit as suggested.
> With that the series is:
> Reviewed-by: Emil Velikov <emil.velikov@...labora.com>
Thanks for reviewing,
Cristian
> HTH o/
> -Emil
Powered by blists - more mailing lists