linux-kernel - Re: [PATCH 0/5] Improve AMD ACP Vangogh audio support for Steam Deck OLED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23ddcf66-7656-466f-9244-f82ffa66e504@collabora.com>
Date:   Mon, 11 Dec 2023 19:04:53 +0200
From:   Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To:     Emil Velikov <emil.velikov@...labora.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Venkata Prasad Potturu <venkataprasad.potturu@....com>,
        Marian Postevca <posteuca@...ex.one>,
        Vijendar Mukunda <Vijendar.Mukunda@....com>,
        Syed Saba Kareem <Syed.SabaKareem@....com>,
        Alper Nebi Yasak <alpernebiyasak@...il.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Rander Wang <rander.wang@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
        Bard Liao <bard.liao@...el.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH 0/5] Improve AMD ACP Vangogh audio support for Steam Deck
 OLED

On 12/11/23 17:12, Emil Velikov wrote:
> On 2023/12/09, Cristian Ciocaltea wrote:
>> This patch series provides several fixes and improvements to AMD ACP drivers
>> targeting the Vangogh platform, as found on the Valve's new Steam Deck OLED.
>>
>> Although in theory the board should have been supported by both SOF and legacy
>> ACP drivers, as of next-20231208 the audio seems to be completely broken.
>>
>> Please note this only restores the legacy support, while SOF will be handled in
>> a separate series.
>>
>> Cristian Ciocaltea (5):
>>   ASoC: amd: vangogh: Drop conflicting ACPI-based probing
>>   ASoC: amd: vangogh: Allow probing ACP PCI when SOF is disabled
>>   ASoC: amd: vangogh: Switch to {RUNTIME,SYSTEM_SLEEP}_PM_OPS
>>   ASoC: amd: acp-config: Add missing MODULE_DESCRIPTION
>>   ASoC: amd: acp: Add missing MODULE_DESCRIPTION in mach-common
>>
> 
> If it were me, I'd drop the Fixes tag in the latter two patches since
> the warning is harmless and as-is it'll get into the -stable
> maintainers' list, who are already pretty swamped with patches.

Sure, I can drop them if there is a need for v2.

> Regardless, for the series:
> Reviewed-by: Emil Velikov <emil.velikov@...labora.com>

Thanks for the review,
Cristian

> HTH
> Emil