linux-kernel - Re: [PATCH --fixes] riscv: Remove SHADOW_OVERFLOW_STACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Dec 2023 09:34:13 -0800
From:   Sami Tolvanen <samitolvanen@...gle.com>
To:     Song Shuai <songshuaishuai@...ylab.org>
Cc:     paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, guoren@...nel.org,
        conor.dooley@...rochip.com, bjorn@...osinc.com, debug@...osinc.com,
        greentime.hu@...ive.com, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH --fixes] riscv: Remove SHADOW_OVERFLOW_STACK_SIZE macro

Hi,

On Mon, Dec 11, 2023 at 3:04 AM Song Shuai <songshuaishuai@...ylab.org> wrote:
>
> The commit be97d0db5f44 ("riscv: VMAP_STACK overflow
> detection thread-safe") got rid of `shadow_stack`,
> so SHADOW_OVERFLOW_STACK_SIZE should be removed too.
>
> Fixes: be97d0db5f44 ("riscv: VMAP_STACK overflow detection thread-safe")
> Signed-off-by: Song Shuai <songshuaishuai@...ylab.org>
> ---
>  arch/riscv/include/asm/thread_info.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/include/asm/thread_info.h b/arch/riscv/include/asm/thread_info.h
> index 574779900bfb..4856697c5f25 100644
> --- a/arch/riscv/include/asm/thread_info.h
> +++ b/arch/riscv/include/asm/thread_info.h
> @@ -28,7 +28,6 @@
>
>  #define THREAD_SHIFT            (PAGE_SHIFT + THREAD_SIZE_ORDER)
>  #define OVERFLOW_STACK_SIZE     SZ_4K
> -#define SHADOW_OVERFLOW_STACK_SIZE (1024)
>
>  #define IRQ_STACK_SIZE         THREAD_SIZE

Ah, good catch. Thanks for the patch!

Reviewed-by: Sami Tolvanen <samitolvanen@...gle.com>

Sami