| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAP-5=fV=zGDU3N093gFVosnmxLtO9n=hb4vfoZtPn3E3HfLvfw@mail.gmail.com>
Date: Mon, 11 Dec 2023 11:31:02 -0800
From: Ian Rogers <irogers@...gle.com>
To: Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Ian Rogers <irogers@...gle.com>,
Adrian Hunter <adrian.hunter@...el.com>,
Suzuki K Poulose <suzuki.poulose@....com>,
Mike Leach <mike.leach@...aro.org>,
James Clark <james.clark@....com>,
Leo Yan <leo.yan@...aro.org>,
John Garry <john.g.garry@...cle.com>,
Will Deacon <will@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Darren Hart <dvhart@...radead.org>,
Davidlohr Bueso <dave@...olabs.net>,
André Almeida <andrealmeid@...lia.com>,
Kan Liang <kan.liang@...ux.intel.com>,
K Prateek Nayak <kprateek.nayak@....com>,
Sean Christopherson <seanjc@...gle.com>,
Paolo Bonzini <pbonzini@...hat.com>,
Kajol Jain <kjain@...ux.ibm.com>,
Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
Andrew Jones <ajones@...tanamicro.com>,
Alexandre Ghiti <alexghiti@...osinc.com>,
Atish Patra <atishp@...osinc.com>,
"Steinar H. Gunderson" <sesse@...gle.com>,
Yang Jihong <yangjihong1@...wei.com>,
Yang Li <yang.lee@...ux.alibaba.com>,
Changbin Du <changbin.du@...wei.com>,
Sandipan Das <sandipan.das@....com>,
Ravi Bangoria <ravi.bangoria@....com>,
Paran Lee <p4ranlee@...il.com>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Huacai Chen <chenhuacai@...nel.org>,
Yanteng Si <siyanteng@...ngson.cn>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
bpf@...r.kernel.org
Subject: Re: [PATCH v1 00/14] Clean up libperf cpumap's empty function
On Tue, Nov 28, 2023 at 10:02 PM Ian Rogers <irogers@...gle.com> wrote:
>
> Rename and clean up the use of libperf CPU map functions particularly
> focussing on perf_cpu_map__empty that may return true for maps
> containing CPUs but also with an "any CPU"/dummy value.
>
> perf_cpu_map__nr is also troubling in that iterating an empty CPU map
> will yield the "any CPU"/dummy value. Reduce the appearance of some
> calls to this by using the perf_cpu_map__for_each_cpu macro.
>
> Ian Rogers (14):
> libperf cpumap: Rename perf_cpu_map__dummy_new
> libperf cpumap: Rename and prefer sysfs for perf_cpu_map__default_new
> libperf cpumap: Rename perf_cpu_map__empty
> libperf cpumap: Replace usage of perf_cpu_map__new(NULL)
> libperf cpumap: Add for_each_cpu that skips the "any CPU" case
> libperf cpumap: Add any, empty and min helpers
> perf arm-spe/cs-etm: Directly iterate CPU maps
> perf intel-pt/intel-bts: Switch perf_cpu_map__has_any_cpu_or_is_empty
> use
> perf cpumap: Clean up use of perf_cpu_map__has_any_cpu_or_is_empty
> perf top: Avoid repeated function calls
> perf arm64 header: Remove unnecessary CPU map get and put
> perf stat: Remove duplicate cpus_map_matched function
> perf cpumap: Use perf_cpu_map__for_each_cpu when possible
> libperf cpumap: Document perf_cpu_map__nr's behavior
Ping. Thanks,
Ian
> .../perf/Documentation/examples/sampling.c | 2 +-
> .../perf/Documentation/libperf-sampling.txt | 2 +-
> tools/lib/perf/Documentation/libperf.txt | 4 +-
> tools/lib/perf/cpumap.c | 92 +++++++++++++------
> tools/lib/perf/evlist.c | 6 +-
> tools/lib/perf/evsel.c | 2 +-
> tools/lib/perf/include/perf/cpumap.h | 56 ++++++++++-
> tools/lib/perf/libperf.map | 10 +-
> tools/lib/perf/tests/test-cpumap.c | 4 +-
> tools/lib/perf/tests/test-evlist.c | 6 +-
> tools/lib/perf/tests/test-evsel.c | 2 +-
> tools/perf/arch/arm/util/cs-etm.c | 83 +++++++----------
> tools/perf/arch/arm64/util/arm-spe.c | 4 +-
> tools/perf/arch/arm64/util/header.c | 15 +--
> tools/perf/arch/x86/util/intel-bts.c | 4 +-
> tools/perf/arch/x86/util/intel-pt.c | 10 +-
> tools/perf/bench/epoll-ctl.c | 2 +-
> tools/perf/bench/epoll-wait.c | 2 +-
> tools/perf/bench/futex-hash.c | 2 +-
> tools/perf/bench/futex-lock-pi.c | 2 +-
> tools/perf/bench/futex-requeue.c | 2 +-
> tools/perf/bench/futex-wake-parallel.c | 2 +-
> tools/perf/bench/futex-wake.c | 2 +-
> tools/perf/builtin-c2c.c | 6 +-
> tools/perf/builtin-ftrace.c | 2 +-
> tools/perf/builtin-record.c | 4 +-
> tools/perf/builtin-stat.c | 31 +------
> tools/perf/tests/bitmap.c | 13 +--
> tools/perf/tests/code-reading.c | 2 +-
> tools/perf/tests/cpumap.c | 2 +-
> tools/perf/tests/keep-tracking.c | 2 +-
> tools/perf/tests/mmap-basic.c | 2 +-
> tools/perf/tests/openat-syscall-all-cpus.c | 2 +-
> tools/perf/tests/perf-time-to-tsc.c | 2 +-
> tools/perf/tests/sw-clock.c | 2 +-
> tools/perf/tests/switch-tracking.c | 2 +-
> tools/perf/tests/task-exit.c | 2 +-
> tools/perf/tests/topology.c | 48 +++++-----
> tools/perf/util/auxtrace.c | 4 +-
> tools/perf/util/bpf_counter.c | 2 +-
> tools/perf/util/bpf_kwork.c | 16 ++--
> tools/perf/util/bpf_kwork_top.c | 12 +--
> tools/perf/util/cpumap.c | 14 ++-
> tools/perf/util/cputopo.c | 2 +-
> tools/perf/util/evlist.c | 4 +-
> tools/perf/util/evsel.c | 2 +-
> tools/perf/util/perf_api_probe.c | 4 +-
> tools/perf/util/record.c | 4 +-
> .../scripting-engines/trace-event-python.c | 12 ++-
> tools/perf/util/session.c | 5 +-
> tools/perf/util/stat.c | 2 +-
> tools/perf/util/svghelper.c | 20 ++--
> tools/perf/util/top.c | 9 +-
> 53 files changed, 296 insertions(+), 254 deletions(-)
>
> --
> 2.43.0.rc1.413.gea7ed67945-goog
>
Powered by blists - more mailing lists