linux-kernel - Re: [PATCH v1] perf stat: Fix help message for --metric-no-threshold option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Dec 2023 11:39:02 -0800
From:   Ian Rogers <irogers@...gle.com>
To:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v1] perf stat: Fix help message for --metric-no-threshold option

On Wed, Nov 29, 2023 at 2:36 PM Ian Rogers <irogers@...gle.com> wrote:
>
> Copy-paste error led to help message for metric-no-threshold repeating
> that of metric-no-merge.
>
> Reported-by: Stephane Eranian <eranian@...gle.com>
> Fixes: 1fd09e299bdd ("perf metric: Add --metric-no-threshold option")
> Signed-off-by: Ian Rogers <irogers@...gle.com>

Ping. Thanks,
Ian

> ---
>  tools/perf/builtin-stat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index a3af805a1d57..c77a3308d3fb 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1255,7 +1255,7 @@ static struct option stat_options[] = {
>         OPT_BOOLEAN(0, "metric-no-merge", &stat_config.metric_no_merge,
>                        "don't try to share events between metrics in a group"),
>         OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_threshold,
> -                      "don't try to share events between metrics in a group  "),
> +                      "disable adding events for the metric threshold calculation"),
>         OPT_BOOLEAN(0, "topdown", &topdown_run,
>                         "measure top-down statistics"),
>         OPT_UINTEGER(0, "td-level", &stat_config.topdown_level,
> --
> 2.43.0.rc1.413.gea7ed67945-goog
>