linux-kernel - Re: [PATCH] power: snapshot: Remove unnecessary ‘0’ values from error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0g873f9jHRfEfBhX4bYeyFR_1zuB_Jga+fKX0Tc7mQX9A@mail.gmail.com>
Date:   Mon, 11 Dec 2023 22:03:50 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Wang chaodong <chaodong@...china.com>
Cc:     rafael@...nel.org, pavel@....cz, len.brown@...el.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: snapshot: Remove unnecessary ‘0’ values from error

On Fri, Oct 20, 2023 at 10:51 AM Wang chaodong <chaodong@...china.com> wrote:
>
> error is assigned first, so it does not need to initialize the assignment.
>
> Signed-off-by: Wang chaodong <chaodong@...china.com>
> ---
>  kernel/power/snapshot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
> index 87e9f7e2bdc05..9acdc4458a36d 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -1119,7 +1119,7 @@ static void mark_nosave_pages(struct memory_bitmap *bm)
>  int create_basic_memory_bitmaps(void)
>  {
>         struct memory_bitmap *bm1, *bm2;
> -       int error = 0;
> +       int error;
>
>         if (forbidden_pages_map && free_pages_map)
>                 return 0;
> --

Applied as 6.8 material with rewritten subject and changelog.

Thanks!