linux-kernel - Re: [RFC PATCH] ring-buffer: Fix and comment ring buffer rb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231211181352.088aeef5@gandalf.local.home>
Date:   Mon, 11 Dec 2023 18:13:52 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:     linux-kernel@...r.kernel.org,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-trace-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] ring-buffer: Fix and comment ring buffer rb_time
 functions on 32-bit

On Mon, 11 Dec 2023 17:59:04 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> > 
> > - A cmpxchg interrupted by 4 writes or cmpxchg overflows the counter
> >   and produces corrupted time stamps. This is _not_ fixed by this patch.  
> 
> Except that it's not 4 bits that is compared, but 32 bits.

That should be "not 2 bits", as in "shave and a hair cut!" ;-)

-- Steve