linux-kernel - Re: [PATCH 1/5] erofs: support I/O submission for sub-page compressed blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fd5a85e-2521-4295-938b-bedb9ee1b67b@linux.alibaba.com>
Date:   Mon, 11 Dec 2023 16:10:51 +0800
From:   Gao Xiang <hsiangkao@...ux.alibaba.com>
To:     linux-erofs@...ts.ozlabs.org
Cc:     LKML <linux-kernel@...r.kernel.org>, dhavale@...gle.com,
        Yue Hu <huyue2@...lpad.com>
Subject: Re: [PATCH 1/5] erofs: support I/O submission for sub-page compressed
 blocks



On 2023/12/6 17:10, Gao Xiang wrote:
> Add a basic I/O submission path first to support sub-page blocks:
> 
>   - Temporary short-lived pages will be used entirely;
> 
>   - In-place I/O pages can be used partially, but compressed pages need
>     to be able to be mapped in contiguous virtual memory.
> 
> As a start, currently cache decompression is explicitly disabled for
> sub-page blocks, which will be supported in the future.
> 
> Signed-off-by: Gao Xiang <hsiangkao@...ux.alibaba.com>

...

> +		cur = mdev.m_pa;
> +		end = cur + pcl->pclusterpages << PAGE_SHIFT;

In this patch, here should be
end = cur + (pcl->pclusterpages << PAGE_SHIFT);

but since this line will be immediately updated in the next patch
as `end = cur + pcl->pclustersize;` so it will have no impact.
I've fixed it up in the development tree.

Thanks,
Gao Xiang