linux-kernel - Re: [PATCH] misc: nsm: remove selecting the non-existing config CBOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19bc8b00-1126-4a29-a127-7c9597b3672d@amazon.com>
Date:   Mon, 11 Dec 2023 10:47:27 +0100
From:   Alexander Graf <graf@...zon.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        <aws-nitro-enclaves-devel@...zon.com>,
        Arnd Bergmann <arnd@...db.de>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] misc: nsm: remove selecting the non-existing config CBOR


On 11.12.23 08:42, Lukas Bulwahn wrote:
> Commit b9873755a6c8 ("misc: Add Nitro Secure Module driver") adds Nitro
> Security Module support, which selects the non-existing config CBOR.
>
> In the development of the commit, there was initially some code for CBOR
> independent of the driver, and the driver included this code with the line
> 'select CBOR'. This code for CBOR was later reduced to its bare minimum of
> functionality and included into the driver itself. The select CBOR remained
> unnoticed and was left behind without having any further purpose.
>
> Remove selecting the non-existing config CBOR.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>


Yikes. Thanks for the catch!

Reviewed-by: Alexander Graf <graf@...zon.com>


Alex


> ---
>   drivers/misc/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 8932b6cf9595..4fb291f0bf7c 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -566,7 +566,6 @@ config NSM
>          tristate "Nitro (Enclaves) Security Module support"
>          depends on VIRTIO
>          select HW_RANDOM
> -       select CBOR
>          help
>            This driver provides support for the Nitro Security Module
>            in AWS EC2 Nitro based Enclaves. The driver exposes a /dev/nsm
> --
> 2.17.1
>



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879