linux-kernel - Re: [PATCH v3 1/3] RAS: Introduce AMD Address Translation Library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231211142055.GHZXcax0W+WD5/YBgm@fat_crate.local>
Date:   Mon, 11 Dec 2023 15:20:55 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Yazen Ghannam <yazen.ghannam@....com>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        tony.luck@...el.com, x86@...nel.org, avadhut.naik@....com,
        john.allen@....com, william.roche@...cle.com,
        muralidhara.mk@....com
Subject: Re: [PATCH v3 1/3] RAS: Introduce AMD Address Translation Library

On Sun, Dec 10, 2023 at 01:49:30PM -0600, Yazen Ghannam wrote:
> diff --git a/drivers/ras/amd/atl/Kconfig b/drivers/ras/amd/atl/Kconfig
> new file mode 100644
> index 000000000000..fcff387faa33
> --- /dev/null
> +++ b/drivers/ras/amd/atl/Kconfig
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +#
> +# AMD Address Translation Library Kconfig
> +#
> +# Copyright (c) 2023, Advanced Micro Devices, Inc.
> +# All Rights Reserved.
> +#
> +# Author: Yazen Ghannam <Yazen.Ghannam@....com>
> +
> +config AMD_ATL
> +	tristate "AMD Address Translation Library"
> +	depends on AMD_NB
> +	imply AMD_ATL_MOD
> +	select AMD_ATL_STUB
> +	default N
> +	help
> +	  This library includes support for implementation-specific
> +	  address translation procedures needed for various error
> +	  handling cases.
> +
> +	  Enable this option if using DRAM ECC on Zen-based systems
> +	  and OS-based error handling.
> +
> +config AMD_ATL_MOD
> +	tristate "AMD Address Translation Library module"
> +	depends on X86_64
> +	default N
> +	help
> +	  This option provides the module component of the AMD Address
> +	  Translation Library. It will be selected automatically if
> +	  building the library. Minimal dependencies are given to avoid
> +	  build errors for modules using the library.
> +
> +config AMD_ATL_STUB
> +	bool "AMD Address Translation Library stub"
> +	default N
> +	help
> +	  This option provides minimal built-in code to support the
> +	  AMD Address Translation Library module. It will be selected
> +	  automatically if building the library. No dependencies are given
> +	  to avoid build errors for modules using the library.

So, provided this stub thing even makes sense (I need to continue
looking first since this is a huge diff), you don't need the help text
and the bool prompt: a stub is prompt-less and is selected
automatically.

IOW:

diff --git a/drivers/ras/amd/atl/Kconfig b/drivers/ras/amd/atl/Kconfig
index fcff387faa33..348498d49b01 100644
--- a/drivers/ras/amd/atl/Kconfig
+++ b/drivers/ras/amd/atl/Kconfig
@@ -32,10 +32,4 @@ config AMD_ATL_MOD
 	  build errors for modules using the library.
 
 config AMD_ATL_STUB
-	bool "AMD Address Translation Library stub"
-	default N
-	help
-	  This option provides minimal built-in code to support the
-	  AMD Address Translation Library module. It will be selected
-	  automatically if building the library. No dependencies are given
-	  to avoid build errors for modules using the library.
+	def_bool N

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette