linux-kernel - Re: [PATCH v3 1/3] RAS: Introduce AMD Address Translation Library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231212153449.GEZXh9mSJ5epD13Dp7@fat_crate.local>
Date:   Tue, 12 Dec 2023 16:34:49 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Yazen Ghannam <yazen.ghannam@....com>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        tony.luck@...el.com, x86@...nel.org, avadhut.naik@....com,
        john.allen@....com, william.roche@...cle.com,
        muralidhara.mk@....com
Subject: Re: [PATCH v3 1/3] RAS: Introduce AMD Address Translation Library

On Tue, Dec 12, 2023 at 09:23:44AM -0500, Yazen Ghannam wrote:
> I'm thinking that the warning only happens if the "assert" condition above
> is hit.

assert usually means "assert - abort the program if assertion is false"
- from assert(3).

> In older revisions, I had all these messages as "debug" loglevel. I don't
> think there's anything a user can do to fix these issues. They're either
> coding bugs in the library or system configuration.
> 
> I'd rather go back to the debug messages if you don't mind. It's not
> difficult to enable dynamic debug messages compared to DEBUG Kconfig
> options. So I think it'd be okay to work with users on this if they
> encounter an issue.

Makes sense.

> > > +static const struct x86_cpu_id amd_atl_cpuids[] = {
> > > +	X86_MATCH_FEATURE(X86_FEATURE_SMCA, NULL),
> > 
> > I'd expect for only this one to be needed, but not those below.
> > 
> 
> Me too. Those below are to workaround a current module loading issue. I'll
> add a code comment for that.

You mean the systemdoofus crap?

Fget it - we don't fix the kernel because luserspace is nuts.

> 
> > > +	X86_MATCH_FEATURE(X86_FEATURE_ZEN, NULL),

...and those are influx - this is called X86_FEATURE_ZEN1 now and
X86_FEATURE_ZEN is set on all Zens. So you might as well match on
X86_FEATURE_ZEN only.

But you should not need it - if SMCA doesn't match then we have another
problem. ATL should load on SMCA systems only.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette