linux-kernel - Re: [PATCH net-next v14 01/13] rtase: Add pci table supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231212080509.48ec4931@kernel.org>
Date:   Tue, 12 Dec 2023 08:05:09 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Justin Lai <justinlai0215@...ltek.com>
Cc:     Paolo Abeni <pabeni@...hat.com>, davem@...emloft.net,
        edumazet@...gle.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, andrew@...n.ch, pkshih@...ltek.com,
        larry.chiu@...ltek.com
Subject: Re: [PATCH net-next v14 01/13] rtase: Add pci table supported in
 this module

On Tue, 12 Dec 2023 10:36:16 +0100 Paolo Abeni wrote:
> > +static void rtase_remove_one(struct pci_dev *pdev)
> > +{
> > +	struct net_device *dev = pci_get_drvdata(pdev);
> > +	struct rtase_private *tp = netdev_priv(dev);
> > +	struct rtase_int_vector *ivec;
> > +	u32 i;
> > +
> > +	for (i = 0; i < tp->int_nums; i++) {
> > +		ivec = &tp->int_vector[i];
> > +		netif_napi_del(&ivec->napi);
> > +	}  
> 
> You must unregister the netdev before napi_del or you will risk races.

Or del them in the ndo_open / ndo_stop... Note that ndo_stop is always
called if ndo_open was called.