linux-kernel - Re: [PATCH] mei: fix vsc dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <af1f937b-37e0-466d-ac94-4f57e086f326@app.fastmail.com>
Date:   Wed, 13 Dec 2023 15:42:08 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Sakari Ailus" <sakari.ailus@...ux.intel.com>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Tomas Winkler" <tomas.winkler@...el.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Wentong Wu" <wentong.wu@...el.com>,
        "Alexander Usyskin" <alexander.usyskin@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mei: fix vsc dependency

On Wed, Dec 13, 2023, at 14:12, Sakari Ailus wrote:
> On Wed, Dec 13, 2023 at 01:43:05PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> The Kconfig dependency in the new module is reversed from the dependency
>> on the exported symbols, so it fails to link with CONFIG_INTEL_MEI_VSC
>> disabled and CONFIG_INTEL_MEI_VSC_HW enabled:
>> @@ -64,6 +64,7 @@ config INTEL_MEI_VSC_HW
>>  	tristate "Intel visual sensing controller device transport driver"
>>  	depends on ACPI && SPI
>>  	depends on GPIOLIB || COMPILE_TEST
>> +	depends on INTEL_MEI_VSC
>
> Oops. The dependency indeed seems to have been reversed.
>
> Could you also reorder the entries so the one that depends on the other
> would be below?

Update: I actually misread the code and the original dependency
appears to have been correct. Instead there is a different bug,
so I'll send a new patch after I have done enough testing on
the new version.

      Armd