linux-kernel - Re: [PATCH] leds: rgb: Drop obsolete dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2023 15:38:38 +0000
From:   Lee Jones <lee@...nel.org>
To:     Jean Delvare <jdelvare@...e.de>
Cc:     Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: rgb: Drop obsolete dependency on COMPILE_TEST

On Sat, 02 Dec 2023, Jean Delvare wrote:

> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Lee Jones <lee@...nel.org>
> ---
>  drivers/leds/rgb/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

It's not clear to me what this patch improves.

Going to choose to keep the status quo on this one.

> --- linux-6.6.orig/drivers/leds/rgb/Kconfig
> +++ linux-6.6/drivers/leds/rgb/Kconfig
> @@ -4,7 +4,7 @@ if LEDS_CLASS_MULTICOLOR
>  
>  config LEDS_GROUP_MULTICOLOR
>  	tristate "LEDs group multi-color support"
> -	depends on OF || COMPILE_TEST
> +	depends on OF
>  	help
>  	  This option enables support for monochrome LEDs that are grouped
>  	  into multicolor LEDs which is useful in the case where LEDs of
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support

-- 
Lee Jones [李琼斯]