linux-kernel - Re: [PATCH V2] f2fs: fix to check return value of f2fs_recover_xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9dc77c35-bcb3-4a87-9926-36a0fa205d17@kernel.org>
Date:   Wed, 13 Dec 2023 09:28:50 +0800
From:   Chao Yu <chao@...nel.org>
To:     Zhiguo Niu <zhiguo.niu@...soc.com>, jaegeuk@...nel.org
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, niuzhiguo84@...il.com,
        ke.wang@...soc.com
Subject: Re: [PATCH V2] f2fs: fix to check return value of
 f2fs_recover_xattr_data

On 2023/12/12 10:15, Zhiguo Niu wrote:
> Should check return value of f2fs_recover_xattr_data in
> __f2fs_setxattr rather than doing invalid retry if error happen.
> 
> Also just do set_page_dirty in f2fs_recover_xattr_data when
> page is changed really.
> 
> Fixes: 50a472bbc79f ("f2fs: do not return EFSCORRUPTED, but try to run online repair")
> Signed-off-by: Zhiguo Niu <zhiguo.niu@...soc.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,