linux-kernel - Re: [PATCH v6 03/40] ARM: ep93xx: add regmap aux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXnp284IpfVEZX6A@smile.fi.intel.com>
Date:   Wed, 13 Dec 2023 19:28:59 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Nikita Shubin <nikita.shubin@...uefel.me>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Damien Le Moal <dlemoal@...nel.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v6 03/40] ARM: ep93xx: add regmap aux_dev

On Tue, Dec 12, 2023 at 11:20:20AM +0300, Nikita Shubin wrote:
> The following driver's should be instantiated by ep93xx syscon driver:
> 
> - reboot
> - pinctrl
> - clock
> 
> They all require access to DEVCFG register with a shared lock held, to
> avoid conflict writing to swlocked parts of DEVCFG.
> 
> Provide common resources such as base, regmap and spinlock via auxiliary
> bus framework.

...

>  struct platform_device;
> +struct regmap;

Perhaps more to add. See below.

...

> +enum ep93xx_soc_model {
> +	EP93XX_9301_SOC,
> +	EP93XX_9307_SOC,
> +	EP93XX_9312_SOC

It doesn't look like a termination, so leave trailing comma.

> +};

...

> +#include <linux/spinlock.h>

I don't see a user for this. Am I missing something?

-- 
With Best Regards,
Andy Shevchenko