linux-kernel - Re: [PATCH v5 1/5] block: Fix bio IO priority setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXnir8x6127EW7Gp@redhat.com>
Date:   Wed, 13 Dec 2023 11:58:23 -0500
From:   Mike Snitzer <snitzer@...nel.org>
To:     Hongyu Jin <hongyu.jin.cn@...il.com>
Cc:     agk@...hat.com, mpatocka@...hat.com, axboe@...nel.dk,
        ebiggers@...nel.org, zhiguo.niu@...soc.com, ke.wang@...soc.com,
        yibin.ding@...soc.com, hongyu.jin@...soc.com,
        linux-kernel@...r.kernel.org, dm-devel@...ts.linux.dev,
        linux-block@...r.kernel.org
Subject: Re: [PATCH v5 1/5] block: Fix bio IO priority setting

On Wed, Dec 13 2023 at  5:42P -0500,
Hongyu Jin <hongyu.jin.cn@...il.com> wrote:

> From: Hongyu Jin <hongyu.jin@...soc.com>
> 
> Move bio_set_ioprio() into submit_bio():
> 1. Only call bio_set_ioprio() once to set the priority of original bio,
>    the bio that cloned and splited from original bio will auto inherit
>    the priority of original bio in clone process.
> 
> 2. The IO priority can be passed to module that implement
>    struct gendisk::fops::submit_bio, help resolve some
>    of the IO priority loss issues.
> 
> This patch depends on commit 82b74cac2849 ("blk-ioprio: Convert from
> rqos policy to direct call")
> 
> Fixes: a78418e6a04c ("block: Always initialize bio IO priority on submit")
> 
> Co-developed-by: Yibin Ding <yibin.ding@...soc.com>
> Signed-off-by: Yibin Ding <yibin.ding@...soc.com>
> Signed-off-by: Hongyu Jin <hongyu.jin@...soc.com>

Would be nice to get this block core fix upstream ASAP independent of
your various DM changes.

Please simplify this patch's header like was requested in review of v4:
https://patchwork.kernel.org/project/dm-devel/patch/20231212111150.18155-2-hongyu.jin.cn@gmail.com/