linux-kernel - Re: [PATCH v4 18/39] netfs: Export netfs_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f8c3f22f77e9e0154f4131260559c39d6740678.camel@kernel.org>
Date:   Wed, 13 Dec 2023 13:01:04 -0500
From:   Jeff Layton <jlayton@...nel.org>
To:     David Howells <dhowells@...hat.com>,
        Steve French <smfrench@...il.com>
Cc:     Matthew Wilcox <willy@...radead.org>,
        Marc Dionne <marc.dionne@...istor.com>,
        Paulo Alcantara <pc@...guebit.com>,
        Shyam Prasad N <sprasad@...rosoft.com>,
        Tom Talpey <tom@...pey.com>,
        Dominique Martinet <asmadeus@...ewreck.org>,
        Eric Van Hensbergen <ericvh@...nel.org>,
        Ilya Dryomov <idryomov@...il.com>,
        Christian Brauner <christian@...uner.io>,
        linux-cachefs@...hat.com, linux-afs@...ts.infradead.org,
        linux-cifs@...r.kernel.org, linux-nfs@...r.kernel.org,
        ceph-devel@...r.kernel.org, v9fs@...ts.linux.dev,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 18/39] netfs: Export netfs_put_subrequest() and some
 tracepoints

On Wed, 2023-12-13 at 15:23 +0000, David Howells wrote:
> Export netfs_put_subrequest() and the netfs_rreq and netfs_sreq
> tracepoints.
> 


Erm...why? Are these called directly from module code in a later patch?
Some rationale for this would be a nice thing.

> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Jeff Layton <jlayton@...nel.org>
> cc: linux-cachefs@...hat.com
> cc: linux-fsdevel@...r.kernel.org
> cc: linux-mm@...ck.org
> ---
>  fs/netfs/main.c    | 3 +++
>  fs/netfs/objects.c | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/fs/netfs/main.c b/fs/netfs/main.c
> index 97ce1436615b..404e68e339bf 100644
> --- a/fs/netfs/main.c
> +++ b/fs/netfs/main.c
> @@ -17,6 +17,9 @@ MODULE_DESCRIPTION("Network fs support");
>  MODULE_AUTHOR("Red Hat, Inc.");
>  MODULE_LICENSE("GPL");
>  
> +EXPORT_TRACEPOINT_SYMBOL(netfs_rreq);
> +EXPORT_TRACEPOINT_SYMBOL(netfs_sreq);
> +
>  unsigned netfs_debug;
>  module_param_named(debug, netfs_debug, uint, S_IWUSR | S_IRUGO);
>  MODULE_PARM_DESC(netfs_debug, "Netfs support debugging mask");
> diff --git a/fs/netfs/objects.c b/fs/netfs/objects.c
> index 9f3f33c93317..a7947e82374a 100644
> --- a/fs/netfs/objects.c
> +++ b/fs/netfs/objects.c
> @@ -178,3 +178,4 @@ void netfs_put_subrequest(struct netfs_io_subrequest *subreq, bool was_async,
>  	if (dead)
>  		netfs_free_subrequest(subreq, was_async);
>  }
> +EXPORT_SYMBOL(netfs_put_subrequest);
> 

-- 
Jeff Layton <jlayton@...nel.org>