linux-kernel - Re: [PATCH v6 16/40] spi: ep93xx: add DT support for Cirrus EP93xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXn0OTsoHcVTly3g@smile.fi.intel.com>
Date:   Wed, 13 Dec 2023 20:13:13 +0200
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Nikita Shubin <nikita.shubin@...uefel.me>
Cc:     Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v6 16/40] spi: ep93xx: add DT support for Cirrus EP93xx

On Tue, Dec 12, 2023 at 11:20:33AM +0300, Nikita Shubin wrote:
> - add OF ID match table
> - add device tree DMA request, so we can probe defer, in case DMA is not
>   ready yet
> - drop DMA platform code

...

> +	espi->dma_rx = dma_request_chan(dev, "rx");
> +	if (IS_ERR(espi->dma_rx)) {
> +		ret = PTR_ERR(espi->dma_rx);
> +		dev_err_probe(dev, ret, "rx DMA setup failed");

		ret = dev_err_probe(...);

>  		goto fail_free_page;
>  	}

...

> +	espi->dma_tx = dma_request_chan(dev, "tx");
> +	if (IS_ERR(espi->dma_tx)) {
> +		ret = PTR_ERR(espi->dma_tx);
> +		dev_err_probe(dev, ret, "tx DMA setup failed");

Ditto.

>  		goto fail_release_rx;
>  	}

...

Otherwise LGTM.

-- 
With Best Regards,
Andy Shevchenko