linux-kernel - Re: [PATCH v6 5/5] selftests/mm: add UFFDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1b0b80a-1cc6-48c4-8a53-0222b3e59c7f@nvidia.com>
Date:   Tue, 12 Dec 2023 18:14:12 -0800
From:   John Hubbard <jhubbard@...dia.com>
To:     Mark Brown <broonie@...nel.org>
CC:     David Hildenbrand <david@...hat.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        <akpm@...ux-foundation.org>, <viro@...iv.linux.org.uk>,
        <brauner@...nel.org>, <shuah@...nel.org>, <aarcange@...hat.com>,
        <lokeshgidra@...gle.com>, <peterx@...hat.com>,
        <ryan.roberts@....com>, <hughd@...gle.com>, <mhocko@...e.com>,
        <axelrasmussen@...gle.com>, <rppt@...nel.org>,
        <willy@...radead.org>, <Liam.Howlett@...cle.com>,
        <jannh@...gle.com>, <zhangpeng362@...wei.com>,
        <bgeffon@...gle.com>, <kaleshsingh@...gle.com>,
        <ngeoffray@...gle.com>, <jdduke@...gle.com>, <linux-mm@...ck.org>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-kselftest@...r.kernel.org>, <kernel-team@...roid.com>,
        Peter Zijlstra <peterz@...radead.org>,
        "Muhammad Usama Anjum" <usama.anjum@...labora.com>
Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test

On 12/12/23 07:12, Mark Brown wrote:
> On Mon, Dec 11, 2023 at 12:29:58PM -0800, John Hubbard wrote:
>> On 12/11/23 12:21, Mark Brown wrote:
...
>> Or maybe there is an innovative way to do all of this, that we have
>> yet to think of.
> 
> We do copy files into tools/include at random times which makes sense
> for things that aren't uapi, and we are putting bits of uapi there
> already so we could just expand the set of files copied there.  AFAICT
> the only reason we're copying the uapi files at all is that they're
> directly in the same include/ directories as everything else and are
> always referenced with their uapi/ prefix.

Oh, this sounds like it would work nicely. No more "make headers"
required (hooray!). Instead, the new approach would be "selftests are
allowed to include from tools/include", and then we can just start
copying the files that we need to that location, and gradually fix up
all the selftests.

I really like this, at first reading anyway.

Muhammad, Shuah, others, what do you think?

+Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>


thanks,
-- 
John Hubbard
NVIDIA