linux-kernel - RE: [PATCH net-next v6 1/6] ptp: clockmatrix: support 32-bit address space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2023 21:04:07 +0000
From:   Min Li <min.li.xe@...esas.com>
To:     Simon Horman <horms@...nel.org>
CC:     Paolo Abeni <pabeni@...hat.com>, Min Li <lnimi@...mail.com>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "lee@...nel.org" <lee@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next v6 1/6] ptp: clockmatrix: support 32-bit address
 space

 
> My reading is that this patch reverses the usage of module and regaddr.
> F.e. the following hunk:
> 
> @@ -553,11 +554,11 @@ static int _sync_pll_output(struct idtcm *idtcm,
> 	val = SYNCTRL1_MASTER_SYNC_RST;
> 
> 	/* Place master sync in reset */
> 	err = idtcm_write(idtcm, 0, sync_ctrl1, &val, sizeof(val));
> 	err = idtcm_write(idtcm, sync_ctrl1, 0, &val, sizeof(val));
> 	if (err)
> 		return err;
> 
> 	err = idtcm_write(idtcm, 0, sync_ctrl0, &sync_src, sizeof(sync_src));
> 	err = idtcm_write(idtcm, sync_ctrl0, 0, &sync_src, sizeof(sync_src));
> 	if (err)
> 		return err;
> 
> If that is really intended I think it needs to be explained, or possibly a
> separate patch.

Hi Simon

sync_ctrl0/1 was meant to be a module and it was in a wrong place. And this patch is just correcting it.