linux-kernel - Re: [PATCH v3 25/29] selftests/resctrl: Introduce generalized test framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19d47295-35af-4046-963f-efb7838c3eaf@intel.com>
Date:   Wed, 13 Dec 2023 14:00:29 -0800
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        <linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
        "Shaopeng Tan" <tan.shaopeng@...fujitsu.com>,
        Maciej Wieczór-Retman 
        <maciej.wieczor-retman@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 25/29] selftests/resctrl: Introduce generalized test
 framework

Hi Ilpo,

On 12/11/2023 4:18 AM, Ilpo Järvinen wrote:
> Each test currently has a "run test" function in per test file and
> another resctrl_tests.c. The functions in resctrl_tests.c are almost
> identical.
> 
> Generalize the one in resctrl_tests.c such that it can be shared
> between all of the tests. It makes adding new tests easier and removes
> the per test if () forests.
> 
> Also add comment to CPU vendor IDs that they must be defined as bits
> for a bitmask.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette