linux-kernel - Re: [PATCH 03/15] kexec: Add Kexec HandOver (KHO) generation helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6748dc7e-534e-4b45-8fa9-052fae591534@amazon.com>
Date:   Thu, 14 Dec 2023 00:36:32 +0100
From:   Alexander Graf <graf@...zon.com>
To:     Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-trace-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <kexec@...ts.infradead.org>, <linux-doc@...r.kernel.org>,
        <x86@...nel.org>, Eric Biederman <ebiederm@...ssion.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mark Rutland <mark.rutland@....com>,
        "Tom Lendacky" <thomas.lendacky@....com>,
        Ashish Kalra <ashish.kalra@....com>,
        James Gowans <jgowans@...zon.com>, <arnd@...db.de>,
        <pbonzini@...hat.com>, <madvenka@...ux.microsoft.com>,
        Anthony Yznaga <anthony.yznaga@...cle.com>,
        Usama Arif <usama.arif@...edance.com>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH 03/15] kexec: Add Kexec HandOver (KHO) generation helpers


On 13.12.23 19:36, Stanislav Kinsburskii wrote:
> On Wed, Dec 13, 2023 at 12:04:40AM +0000, Alexander Graf wrote:
>> +int register_kho_notifier(struct notifier_block *nb)
>> +{
>> +     return blocking_notifier_chain_register(&kho.chain_head, nb);
>> +}
>> +EXPORT_SYMBOL_GPL(register_kho_notifier);
>> +
>> +int unregister_kho_notifier(struct notifier_block *nb)
>> +{
>> +     return blocking_notifier_chain_unregister(&kho.chain_head, nb);
>> +}
>> +EXPORT_SYMBOL_GPL(unregister_kho_notifier);
>> +
>> +bool kho_is_active(void)
>> +{
>> +     return kho.active;
>> +}
>> +EXPORT_SYMBOL_GPL(kho_is_active);
>> +
> Why should these helpers be restricted to GPL code?


That's a simple one: Everything should be EXPORT_SYMBOL_GPL by default. 
You need to have really good reasons to export anything for non-GPL 
modules. I don't have a good reason for them, so it's GPL only :)


Alex





Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879