linux-kernel - Re: [PATCH v12 1/5] asm-generic: Improve csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <129fa764-dc7a-4979-95e8-39a15c487095@app.fastmail.com>
Date:   Wed, 13 Dec 2023 08:52:01 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Charlie Jenkins" <charlie@...osinc.com>,
        "Palmer Dabbelt" <palmer@...belt.com>,
        "Conor Dooley" <conor@...nel.org>,
        "Samuel Holland" <samuel.holland@...ive.com>,
        "David Laight" <David.Laight@...lab.com>,
        "Xiao W Wang" <xiao.w.wang@...el.com>,
        "Evan Green" <evan@...osinc.com>, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Linux-Arch <linux-arch@...r.kernel.org>
Cc:     "Paul Walmsley" <paul.walmsley@...ive.com>,
        "Albert Ou" <aou@...s.berkeley.edu>
Subject: Re: [PATCH v12 1/5] asm-generic: Improve csum_fold

On Wed, Dec 13, 2023, at 02:18, Charlie Jenkins wrote:
> This csum_fold implementation introduced into arch/arc by Vineet Gupta
> is better than the default implementation on at least arc, x86, and
> riscv. Using GCC trunk and compiling non-inlined version, this
> implementation has 41.6667%, 25% fewer instructions on riscv64, x86-64
> respectively with -O3 optimization. Most implmentations override this
> default in asm, but this should be more performant than all of those
> other implementations except for arm which has barrel shifting and
> sparc32 which has a carry flag.
>
> Signed-off-by: Charlie Jenkins <charlie@...osinc.com>

Acked-by: Arnd Bergmann <arnd@...db.de>