linux-kernel - Re: [PATCH v1 1/2] thermal/debugfs: Add thermal cooling device debugfs information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2023 15:57:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>, rjw@...ysocki.net,
        lukasz.luba@....com
Cc:     oe-kbuild-all@...ts.linux.dev, rui.zhang@...el.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v1 1/2] thermal/debugfs: Add thermal cooling device
 debugfs information

Hi Daniel,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/thermal]
[also build test ERROR on linus/master v6.7-rc5 next-20231213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniel-Lezcano/thermal-debugfs-Add-thermal-debugfs-information-for-mitigation-episodes/20231213-001321
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link:    https://lore.kernel.org/r/20231212161047.1631077-1-daniel.lezcano%40linaro.org
patch subject: [PATCH v1 1/2] thermal/debugfs: Add thermal cooling device debugfs information
config: i386-defconfig (https://download.01.org/0day-ci/archive/20231213/202312131518.2Fjrrxot-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231213/202312131518.2Fjrrxot-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312131518.2Fjrrxot-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/thermal/thermal_core.h:16:0,
                    from drivers/thermal/thermal_core.c:27:
   drivers/thermal/thermal_debugfs.h: In function 'thermal_debug_cdev_add':
>> drivers/thermal/thermal_debugfs.h:10:50: error: parameter name omitted
    static inline void thermal_debug_cdev_add(struct thermal_cooling_device *) {}
                                                     ^~~~~~~~~~~~~~~~~~~~~~
   drivers/thermal/thermal_debugfs.h: In function 'thermal_debug_cdev_remove':
   drivers/thermal/thermal_debugfs.h:11:53: error: parameter name omitted
    static inline void thermal_debug_cdev_remove(struct thermal_cooling_device *) {}
                                                        ^~~~~~~~~~~~~~~~~~~~~~
   drivers/thermal/thermal_debugfs.h: In function 'thermal_debug_cdev_transition':
   drivers/thermal/thermal_debugfs.h:12:57: error: parameter name omitted
    static inline void thermal_debug_cdev_transition(struct thermal_cooling_device *, int) {}
                                                            ^~~~~~~~~~~~~~~~~~~~~~
   drivers/thermal/thermal_debugfs.h:12:57: error: parameter name omitted


vim +10 drivers/thermal/thermal_debugfs.h

     2	
     3	#ifdef CONFIG_THERMAL_DEBUGFS
     4	void thermal_debug_init(void);
     5	void thermal_debug_cdev_add(struct thermal_cooling_device *cdev);
     6	void thermal_debug_cdev_remove(struct thermal_cooling_device *cdev);
     7	void thermal_debug_cdev_transition(struct thermal_cooling_device *cdev, int state);
     8	#else
     9	static inline void thermal_debug_init(void) {}
  > 10	static inline void thermal_debug_cdev_add(struct thermal_cooling_device *) {}

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki