[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fb29c3bca8d245e3f7496539b7293aa4fc4bccd0.camel@crapouillou.net>
Date: Wed, 13 Dec 2023 10:55:46 +0100
From: Paul Cercueil <paul@...pouillou.net>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Biju Das <biju.das.jz@...renesas.com>,
Claudiu Beznea <claudiu.beznea.uj@...renesas.com>,
Jianlong Huang <jianlong.huang@...rfivetech.com>,
linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
linux-mips@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Cc: Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
Dong Aisheng <aisheng.dong@....com>,
Fabio Estevam <festevam@...il.com>,
Shawn Guo <shawnguo@...nel.org>, Jacky Bai <ping.bai@....com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Sascha Hauer <s.hauer@...gutronix.de>,
NXP Linux Team <linux-imx@....com>,
Sean Wang <sean.wang@...nel.org>,
Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>,
Emil Renner Berthing <kernel@...il.dk>,
Hal Feng <hal.feng@...rfivetech.com>
Subject: Re: [PATCH v5 03/13] pinctrl: ingenic: Use C99 initializers in
PINCTRL_PIN_GROUP()
Hi Andy,
Le lundi 11 décembre 2023 à 20:57 +0200, Andy Shevchenko a écrit :
> For the better flexibility use C99 initializers in
> PINCTRL_PIN_GROUP().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> drivers/pinctrl/pinctrl-ingenic.c | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c
> b/drivers/pinctrl/pinctrl-ingenic.c
> index ee718f6e2556..f5661dcdedf5 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -82,16 +82,21 @@
> #define PINS_PER_GPIO_CHIP 32
> #define JZ4730_PINS_PER_PAIRED_REG 16
>
> -#define INGENIC_PIN_GROUP_FUNCS(name, id, funcs) \
> - { \
> - name, \
> - id##_pins, \
> - ARRAY_SIZE(id##_pins), \
> - funcs, \
> +#define INGENIC_PIN_GROUP_FUNCS(_name_, id,
> funcs) \
> + {
> \
> + .name =
> _name_, \
> + .pins =
> id##_pins, \
> + .num_pins =
> ARRAY_SIZE(id##_pins), \
> + .data =
> funcs, \
> }
>
> -#define INGENIC_PIN_GROUP(name, id, func) \
> - INGENIC_PIN_GROUP_FUNCS(name, id, (void *)(func))
> +#define INGENIC_PIN_GROUP(_name_, id,
> func) \
> + {
> \
> + .name =
> _name_, \
> + .pins =
> id##_pins, \
> + .num_pins =
> ARRAY_SIZE(id##_pins), \
> + .data = (void
> *)func, \
> + }
This INGENIC_PIN_GROUP() macro doesn't need to be modified, does it?
Cheers,
-Paul
>
> enum jz_version {
> ID_JZ4730,
Powered by blists - more mailing lists