linux-kernel - Re: [PATCH] clocksource: ep93xx: fix error handling during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e40d76c-b4e7-4ed9-9d37-f0f7850f07a1@linaro.org>
Date:   Wed, 13 Dec 2023 11:28:29 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Nikita Shubin <nikita.shubin@...uefel.me>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Alexander Sverdlin <alexander.sverdlin@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource: ep93xx: fix error handling during probe

On 12/12/2023 22:46, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When the interrupt property fails to be parsed, ep93xx_timer_of_init()
> return code ends up uninitialized:
> 
> drivers/clocksource/timer-ep93xx.c:160:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
>          if (irq < 0) {
>              ^~~~~~~
> drivers/clocksource/timer-ep93xx.c:188:9: note: uninitialized use occurs here
>          return ret;
>                 ^~~
> drivers/clocksource/timer-ep93xx.c:160:2: note: remove the 'if' if its condition is always false
>          if (irq < 0) {
>          ^~~~~~~~~~~~~~
> 
> Simplify this portion to use the normal construct of just checking
> whether a valid interrupt was returned. Note that irq_of_parse_and_map()
> never returns a negative value and no other callers check for that either.
> 
> Fixes: c28ca80ba3b5 ("clocksource: ep93xx: Add driver for Cirrus Logic EP93xx")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Applied, thanks

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog