linux-kernel - Re: [PATCH] iommu/sva: Fix memory leak in iommu_sva_bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eef82056-ef8f-4f53-a512-1a39ea9e90f3@oracle.com>
Date:   Wed, 13 Dec 2023 16:43:23 +0530
From:   Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
To:     Joerg Roedel <joro@...tes.org>, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Cc:     dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org,
        error27@...il.com
Subject: Re: [PATCH] iommu/sva: Fix memory leak in iommu_sva_bind_device()

Hi,
On 13/12/23 4:37 pm, Harshit Mogalapalli wrote:
> Free the handle when the domain allocation fails before unlocking and
> returning.
> 

Please ignore this patch, I have missed CCing correct list and few 
maintainers, will resend it correctly.

Thanks,
Harshit
> Fixes: 092edaddb660 ("iommu: Support mm PASID 1:n with sva domains")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> ---
> This is based on static analysis with smatch, only compile tested.
> ---
>   drivers/iommu/iommu-sva.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c
> index 5175e8d85247..c3fc9201d0be 100644
> --- a/drivers/iommu/iommu-sva.c
> +++ b/drivers/iommu/iommu-sva.c
> @@ -101,7 +101,7 @@ struct iommu_sva *iommu_sva_bind_device(struct device *dev, struct mm_struct *mm
>   	domain = iommu_sva_domain_alloc(dev, mm);
>   	if (!domain) {
>   		ret = -ENOMEM;
> -		goto out_unlock;
> +		goto out_free_handle;
>   	}
>   
>   	ret = iommu_attach_device_pasid(domain, dev, iommu_mm->pasid);
> @@ -118,6 +118,7 @@ struct iommu_sva *iommu_sva_bind_device(struct device *dev, struct mm_struct *mm
>   
>   out_free_domain:
>   	iommu_domain_free(domain);
> +out_free_handle:
>   	kfree(handle);
>   out_unlock:
>   	mutex_unlock(&iommu_sva_lock);